Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preferred Topology URL for the namespaces JSON #609

Merged

Conversation

matyasselmeci
Copy link
Contributor

No description provided.

Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the default listed for TopologyNamespaceURL in docs/parameters.yaml?

@jhiemstrawisc
Copy link
Member

Also, for my own understanding, is there a difference outside of the URL for these two topology endpoints?

@matyasselmeci
Copy link
Contributor Author

Nope. Literally the same.

@app.route("/osdf/namespaces")
@app.route("/stashcache/namespaces")
@app.route("/stashcache/namespaces.json")  # for testing; remove before merging
@support_cors
def stashcache_namespaces_json():

https://github.com/opensciencegrid/topology/blob/4ff299dc9c4fd3ab68aeafb859acf1d936f3c4ce/src/app.py#L501-L505

/me blushes at 1.5-year-old comment

@jhiemstrawisc jhiemstrawisc merged commit 802d0b2 into PelicanPlatform:main Jan 8, 2024
8 checks passed
@matyasselmeci matyasselmeci deleted the pr/preferred-topology-url branch January 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants