-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit main process if error group goroutine returns error #671
Conversation
072d5d0
to
e336cbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tweaks; also the changes in director/redirect.go
seem unrelated to this issue and should be in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes requested. Also spotted another way shutdown could get stuck that's specific to the cache; should fix it while we're working in this area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with latest revisions.
@joereuss12 - I believe you were the 7.4.0 release manager, right? If so, can you please backport this PR to that branch and do a bugfix release for @matyasselmeci?
Just cut a bugfix release! |
Fixes #661
root.go
already had.However, this didn't fix the issue where when we exit the program withctrl+c
, xrootd reported error as it treated SIGINT similar as SIGSEGV. We might have to refactor some of the code indaemon/launch_unix.go
. Created a separate issue for this: #672