Skip to content

need to add a configure_requires entry for self at 7.05_01 if a version range is seen #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karenetheridge opened this issue Apr 11, 2015 · 6 comments
Closed

need to add a configure_requires entry for self at 7.05_01 if a version range is seen #215

karenetheridge opened this issue Apr 11, 2015 · 6 comments
Labels
Blocking Stable

Comments

@karenetheridge
Copy link
Member

I used a range here: https://metacpan.org/source/ETHER/Dist-Zilla-Plugin-PromptIfStale-0.041/Makefile.PL#L24

In earlier EUMMs the version range is treated as 0, rather than respecting the stated prereq.
@karenetheridge
Copy link
Member Author

reference: https://rt.cpan.org/Ticket/Display.html?id=75758

@kentfredric kentfredric mentioned this issue Apr 11, 2015
Closed
@karenetheridge karenetheridge mentioned this issue Apr 16, 2015
Closed
@karenetheridge
Copy link
Member Author

This should happen before 7.06 is released.

karenetheridge added a commit to avar/dist-zilla-plugin-makemaker-awesome that referenced this issue May 21, 2015
@karenetheridge
warn the user if passing version ranges to EUMM, which are treated as 0
4f0ecc9 
see Perl-Toolchain-Gang/ExtUtils-MakeMaker#215
karenetheridge added a commit to karenetheridge/Dist-Zilla that referenced this issue May 21, 2015
@karenetheridge
warn the user if passing version ranges to EUMM, which are treated as 0
b64902e 
see Perl-Toolchain-Gang/ExtUtils-MakeMaker#215
karenetheridge added a commit to avar/dist-zilla-plugin-makemaker-awesome that referenced this issue May 21, 2015
@karenetheridge
Dist-Zilla-Plugin-MakeMaker-Awesome-0.34
33752a4 
  - issue a warning when version ranges are passed through to
    ExtUtils::MakeMaker, which cannot parse them and treats them as '0'
    (see Perl-Toolchain-Gang/ExtUtils-MakeMaker#215)
  - omit EXE_FILES argument to WriteMakefile() if there are no such files
@karenetheridge karenetheridge mentioned this issue May 21, 2015
Closed
karenetheridge added a commit to karenetheridge/Dist-Zilla that referenced this issue May 21, 2015
@karenetheridge
warn the user if passing version ranges to EUMM, which are treated as 0
42b7c9e 
see Perl-Toolchain-Gang/ExtUtils-MakeMaker#215
karenetheridge added a commit to karenetheridge/Dist-Zilla that referenced this issue Jun 5, 2015
@karenetheridge
warn the user if passing version ranges to EUMM, which are treated as 0
b06ada9 
see Perl-Toolchain-Gang/ExtUtils-MakeMaker#215
rjbs pushed a commit to rjbs/Dist-Zilla that referenced this issue Jun 5, 2015
@karenetheridge @rjbs
warn the user if passing version ranges to EUMM, which are treated as 0
de4746f 
see Perl-Toolchain-Gang/ExtUtils-MakeMaker#215
rjbs added a commit to rjbs/Dist-Zilla that referenced this issue Jun 5, 2015
@rjbs
v5.037
b3452f1 
        - issue a warning when version ranges are passed through to
          ExtUtils::MakeMaker, which cannot parse them and treats them as '0'
          Perl-Toolchain-Gang/ExtUtils-MakeMaker#215

        - added %P formatter code to [NextRelease] for the releaser's PAUSE id
@karenetheridge
Copy link
Member Author

This should happen before 7.06 is released.

bump 7.05x changes the handling of version ranges. It's important this carry over to the user side.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Aug 16, 2015
(pkgsrc)
6fd3441 
 - Add following line for make test to pass
   BUILD_DEPENDS+=	p5-CPAN-Meta-Check-[0-9]*:../../devel/p5-CPAN-Meta-Check
   BUILD_DEPENDS+=	p5-IPC-Run-[0-9]*:../../devel/p5-IPC-Run
   BUILD_DEPENDS+=	p5-Log-Log4perl-[0-9]*:../../devel/p5-Log-Log4perl
   BUILD_DEPENDS+=	p5-Test-FailWarnings-[0-9]*:../../devel/p5-Test-FailWarnings

(upstream)
 - Update 5.036 to 5.039
---------------------
5.039     2015-08-10 09:03:08-04:00 America/New_York
        - update required version of MooseX::Role::Parameterized; older
          versions work, but can cause a bunch of unwanted warnings

5.038     2015-08-07 22:16:50-04:00 America/New_York
        - [License] can be given a filename option to use instead of LICENSE
        - dzil listdeps --develop now exists as an alias for dzil listdeps
          --author (Karen Etheridge)
        - dzil authordeps now lists the Software::License class needed
          (thanks, David Zurborg)
        - PkgVersion now skips .pod files (thanks, David Golden)
        - build_element support added for [ModuleBuild] (thanks, David
          Wheeler!)
        - new native filefinder :ExtraTestFiles (thanks, Karen Etheridge)
        - [AutoPrereqs] now looks for develop prerequisites in xt/ (thanks,
          Karen Etheridge)
        - new file finder ':PerlExecFiles' (thanks, Karen Etheridge)
        - try harder to notice failure to set up build root, especially on
          Win32 (thanks, Christian Walde)
        - better errors when a global config package isn't available (thanks,
          Karen Etheridge)
        - added the "ignore" option to [Encoding] (thanks, Yanick Champoux)
        - allow ; authordep specifications to contain version ranges (thanks,
          Karen Etheridge)
        - better error when PAUSE credentials can't be loaded (thanks, David
          Golden)
        - fix documentation for the LicenseProvider role
        - improve errors when PPI failes to parse (thanks, Nick Tonkin)
        - sort list of executable files in Makefile.PL, for deterministic
          builds (thanks, Karen Etheridge)
        - omit configure-requires prerequisites from [MakeMaker]'s fallback
          prerequisites (used by older ExtUtils::MakeMaker)

5.037     2015-06-04 21:46:38-04:00 America/New_York
        - issue a warning when version ranges are passed through to
          ExtUtils::MakeMaker, which cannot parse them and treats them as '0'
          Perl-Toolchain-Gang/ExtUtils-MakeMaker#215

        - added %P formatter code to [NextRelease] for the releaser's PAUSE id
@karenetheridge karenetheridge mentioned this issue Mar 18, 2016
Closed
@mohawk2
Copy link
Member

mohawk2 commented Mar 19, 2016

@karenetheridge I agree this needs dealing with (cf #252). Would you agree that rather than 7.05_01, the min version should instead be 7.11_01 since .06-.10 wouldn't be suitable?

@karenetheridge
Copy link
Member Author

Would you agree that rather than 7.05_01, the min version should instead be 7.11_01

I think so, yes.

..although others are making a legitimate case that we don't inject minimum versions when other features are seen (e.g. TEST_REQUIRES)... So I wonder if a simple warning would instead be sufficient?

warn "hey, you're using this feature, which won't work right before 7.1101, but you're not specifying that minimum version. Are you sure? because that's not going to work very well.";

@mohawk2 mohawk2 mentioned this issue Mar 19, 2016
Open
@karenetheridge
Copy link
Member Author

After great reflection I think this is a wrong-headed idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocking Stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dolmen @karenetheridge @mohawk2