Skip to content

[Meta] 7.12 release #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leont opened this issue Feb 12, 2016 · 11 comments
Closed

[Meta] 7.12 release #252

Leont opened this issue Feb 12, 2016 · 11 comments

Comments

@Leont
Copy link
Member

Leont commented Feb 12, 2016

What is left to do before we can release a 7.12?

@bingos
Copy link
Member

bingos commented Feb 12, 2016

I unfortunately dropped the ball on this.

There are two issues as I recall.
And rt.cpan.org is not responding at the moment to link the salient tickets (502 Proxy Error)

Okay, it is available again:

There is this one: https://rt.cpan.org/Ticket/Display.html?id=109962
And #247

@mohawk2
Copy link
Member

mohawk2 commented Feb 14, 2016

#253 addresses #247.

@Leont
Copy link
Member Author

Leont commented Feb 14, 2016

There is this one: https://rt.cpan.org/Ticket/Display.html?id=109962

I wouldn't be surprised if that started depending on the new -o behavior in the short time that such MakeMaker's were out (see b6eb3c32). Possibles the fixes could be to add XSMULTI to the Makefile.PL, or to revert that commit.

@mohawk2
Copy link
Member

mohawk2 commented Feb 14, 2016

The Prima failure was due to its Makefile.PL relying on the generated Makefile having no space before the : in the rule in the c_o override. The pull request above removes that reliance.

@Leont
Copy link
Member Author

Leont commented Mar 18, 2016

I think both of these issues are resolved now, is there anything left that's keeping us from a 7.12 release?

@karenetheridge
Copy link
Member

#215 is marked as "blocking stable". I took a brief look at it a while ago and I think it's straightforward to do, for someone who knows the right bits of code to be modified.

@Leont
Copy link
Member Author

Leont commented Mar 18, 2016

I'm not sure why that would be a blocking issue. We've never done automatic minimum version detection before, why would it be required now? Not that it wouldn't be nice to have, but doing it only for this one feature seems a bit silly to me.

@karenetheridge
Copy link
Member

@Leont version range support is new. before, they were never handled properly (they were interpreted as '0'), but now that new EUMM versions support them, they might start being used in distributions. I think this is different from other features (e.g. TEST_REQUIRES) in that those other options would simply be ignored by earlier EUMMs (with a visible warning), but a version range will be silently accepted but turned into something that the author didn't intend. So my contention was that some sort of backcompat handling should have been done before the original feature (version range support) was ever shipped as stable.

@mohawk2
Copy link
Member

mohawk2 commented Mar 20, 2016

Following the discussion of #260 it seems as though that's not now a blocker. That implies to me that 7.11_05 is an RC for 7.12? Or is there more to do?

@haarg
Copy link
Member

haarg commented Mar 21, 2016

#260 is definitely not a blocker.

@bingos
Copy link
Member

bingos commented Apr 21, 2016

Shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants