refactor init_MAN3PODS so pod files get priority #257
+31
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appears to be failing the XS tests |
|
The crucial error appears to be |
This moves the name transforming code into the initial loop through PM, building a hash keyed by the final man name. Pod files will take priority over pm files, which will take priority over pl files. We only check the pm/pl files for Pod once we know that they will be used.
haarg
force-pushed
the
topic/man-pod-over-pm
branch
from
bfa0bbb to
6e47258
Compare
|
Commenting here because I gather the branch got rebased, and the Travis is still failing, same reason. The "lib/XS/type" error is immediately because the typemap is called "lib/XS/type map" and the dependency isn't being quoted. But I'd argue that this shows more things are being included into this set of files than necessary, since how would that be manify-ed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the name transforming code into the initial loop through PM,
building a hash keyed by the final man name. Pod files will take
priority over pm files, which will take priority over pl files. We only
check the pm/pl files for Pod once we know that they will be used.
I have not yet written tests for this.
This fixes #256.