Skip to content

Fix docker build with Perl < v5.34 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 7, 2025

Conversation

happy-barney
Copy link
Contributor

Reason was increased required Perl version by module Dist::Zilla::PluginBundle::RJBS.

Bonus:

Pull request also contains new cpanfile helper function allowing to declare multiple required versions of module.
Once adapted, cpanfile requirements can be ordered alphabetically.

@oalders
Copy link
Collaborator

oalders commented May 3, 2025

This still has some unhappy checks. 😄

@happy-barney happy-barney force-pushed the hpb/fix-cpanfile-versions branch 2 times, most recently from 43b3d8b to 48bb770 Compare May 3, 2025 16:55
@oalders
Copy link
Collaborator

oalders commented May 3, 2025

This has a merge conflict.

@happy-barney happy-barney force-pushed the hpb/fix-cpanfile-versions branch from 48bb770 to 78d9816 Compare May 6, 2025 16:51
Copy link
Member

@atoomic atoomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice the smoker failure for 5.12 from the Actions

FAIL Test2-Harness-2.000005 requires perl 5.014000, but you have only 5.012005

@happy-barney happy-barney force-pushed the hpb/fix-cpanfile-versions branch from 5826240 to 098569f Compare May 7, 2025 04:32
@happy-barney happy-barney force-pushed the hpb/fix-cpanfile-versions branch from 098569f to c5a7187 Compare May 7, 2025 04:49
@happy-barney
Copy link
Contributor Author

@atoomic older JUnit renderer is now indexed again so 5.012 works as well

@atoomic atoomic merged commit 5c9709a into Perl:main May 7, 2025
18 checks passed
@atoomic
Copy link
Member

atoomic commented May 7, 2025

Thanks this is now merged

@happy-barney happy-barney deleted the hpb/fix-cpanfile-versions branch May 7, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants