-
Notifications
You must be signed in to change notification settings - Fork 15
Fix docker build with Perl < v5.34 #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still has some unhappy checks. 😄 |
43b3d8b
to
48bb770
Compare
This has a merge conflict. |
48bb770
to
78d9816
Compare
atoomic
approved these changes
May 7, 2025
atoomic
requested changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice the smoker failure for 5.12
from the Actions
FAIL Test2-Harness-2.000005 requires perl 5.014000, but you have only 5.012005
atoomic
reviewed
May 7, 2025
5826240
to
098569f
Compare
Function allows to specify multiple required version based on Perl version. Usable when module changes their Perl requirements.
Software::License - 0.104006
098569f
to
c5a7187
Compare
@atoomic older JUnit renderer is now indexed again so |
atoomic
approved these changes
May 7, 2025
Thanks this is now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason was increased required Perl version by module
Dist::Zilla::PluginBundle::RJBS
.Bonus:
Pull request also contains new
cpanfile
helper function allowing to declare multiple required versions of module.Once adapted,
cpanfile
requirements can be ordered alphabetically.