Unicode::UCD Handle properties that have no code points #23134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauke
reviewed
Mar 19, 2025
khwilliamson
force-pushed
the
UCD_16.0
branch
2 times, most recently
from
923f871 to
9b22fca
Compare
mauke
reviewed
Mar 19, 2025
lib/Unicode/UCD.pm
Outdated
| @@ -4180,7 +4180,9 @@ RETRY: | |||
| } # End of loop constructing the converted list | |||
|
|
|||
| # Finish up the data structure for our converted swash | |||
| my $type = ($second_try eq 'nfkccf') ? 'ToNFKCCF' : 'ToDm'; | |||
| my $type = ($second_try =~ / ^ ( nfkcs?cf ) \z /x) | |||
| ? 'To' . $1 | |||
There was a problem hiding this comment.
Should this be 'To' . uc($1)?
There was a problem hiding this comment.
It would be better to use the uc, so I have changed it, thank you. But the tests that failed before this commit in the original form started to pass, so it isn't strictly necesary.
A new property is being added that needs the same special handling as a similar existing one And use \z instead of $ boundary conditions. Spotted by Lukas Mai
This situation had not come up before Unicode 16.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has long been done for matching properties. But it has never
happened before Unicode 16.0 that an entire mapping property would have
no code points.