locale.c: Don't do asymmetric back out on failure #23172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #23519 When something goes wrong doing locale-aware string collation, the code attempts to carry on as well as can be expected. Prior to this commit the backout code was asymmetric, trying to undo things that had not been done. This happened when the failure was early on. In the case of this ticket, the platform has a defective locale that was detectable before getting very far along. The solution adopted here is to jump to a different label for those early failures that does less backout than for later failures.
khwilliamson
force-pushed
the
smoke-me/khw-darwin_locale
branch
from
eb43f7f to
b9e1bad
Compare
|
It's not clear to me if |
|
There's a few paths where they can leak. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #23159
When something goes wrong doing locale-aware string collation, the code attempts to carry on as well as can be expected. prior to this commit the backout code was asymmetric, trying to undo things that had not been done. This happened when the failure was early on.
In the case of this ticket, the platform has a defective locale that was detectable before getting very far along.
The solution adopted here is to jump to a different label for those early failures that does less backout than for later failures.