Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stoa0255.stoa004_first_pass #594

Merged
merged 4 commits into from
Feb 11, 2025
Merged

stoa0255.stoa004_first_pass #594

merged 4 commits into from
Feb 11, 2025

Conversation

AlisonBabeu
Copy link
Contributor

Re #593

Updated cts_xml and metadata for first Seneca file.
Also want to see if build passes with two files.

Updated cts_xml and metadata for first Seneca file.
Also want to see if build passes with two files.
@AlisonBabeu AlisonBabeu requested a review from lcerrato February 6, 2025 21:03
Copy link
Contributor

@lcerrato lcerrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would eliminate the parenthetical and just go with John William.

<cts:label xml:lang="eng">de Brevitate Vitae, Moral essays Vol 2</cts:label>
<cts:description xml:lang="eng">Seneca, Lucius Annaeus, ca. 4 B.C.-65 A.D, creator; Basore, John W. (John William), b. 1870, editor; Basore, John W. (John William), b. 1870, editor, translator</cts:description>
<cts:label xml:lang="lat">De Brevitate Vitae</cts:label>
<cts:description xml:lang="eng">Seneca, Lucius Annaeus. Moral Essays, Volume 2. Basore, John W. (John William), editor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are expanding names, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @lcerrato yes we are, I will make those changes for the other files as well.

@AlisonBabeu AlisonBabeu merged commit 6363776 into master Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants