Skip to content

Make dialogs for SFTP, FTP, Mega, WebDav and Nextcloud not cancelable #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

Make dialogs for SFTP, FTP, Mega, WebDav and Nextcloud not cancelable #2954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/keepass2android-app/FileSelectHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,8 @@ private void ShowSftpDialog(Activity activity, Util.FileSelectedHandler onStartB

builder.SetNegativeButton(Android.Resource.String.Cancel, evtH);
builder.SetTitle(activity.GetString(Resource.String.enter_sftp_login_title));
Dialog dialog = builder.Create();
builder.SetCancelable(false);
Dialog dialog = builder.Create();

dialog.Show();
#endif
Expand Down Expand Up @@ -351,7 +352,8 @@ private void ShowHttpDialog(Activity activity, Util.FileSelectedHandler onStartB

builder.SetNegativeButton(Android.Resource.String.Cancel, evtH);
builder.SetTitle(activity.GetString(Resource.String.enter_http_login_title));
Dialog dialog = builder.Create();
builder.SetCancelable(false);
Dialog dialog = builder.Create();

dialog.Show();
#endif
Expand Down Expand Up @@ -454,7 +456,8 @@ private void ShowFtpDialog(Activity activity, Util.FileSelectedHandler onStartBr

builder.SetNegativeButton(Android.Resource.String.Cancel, evtH);
builder.SetTitle(activity.GetString(Resource.String.enter_ftp_login_title));
Dialog dialog = builder.Create();
builder.SetCancelable(false);
Dialog dialog = builder.Create();

dialog.Show();
#endif
Expand Down Expand Up @@ -514,7 +517,8 @@ private void ShowMegaDialog(Activity activity, Util.FileSelectedHandler onStartB

builder.SetNegativeButton(Android.Resource.String.Cancel, evtH);
builder.SetTitle(activity.GetString(Resource.String.enter_mega_login_title));
Dialog dialog = builder.Create();
builder.SetCancelable(false);
Dialog dialog = builder.Create();

dialog.Show();
#endif
Expand Down Expand Up @@ -579,7 +583,8 @@ private void ShowOwncloudDialog(Activity activity, Util.FileSelectedHandler onSt

builder.SetNegativeButton(Android.Resource.String.Cancel, evtH);
builder.SetTitle(activity.GetString(subtype == "owncloud" ? Resource.String.enter_owncloud_login_title : Resource.String.enter_nextcloud_login_title));
Dialog dialog = builder.Create();
builder.SetCancelable(false);
Dialog dialog = builder.Create();
dlgContents.FindViewById<EditText>(Resource.Id.owncloud_url).SetHint(subtype == "owncloud" ? Resource.String.hint_owncloud_url : Resource.String.hint_nextcloud_url);
dialog.Show();
#endif
Expand Down
Loading