Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Highly Customized] Burst without delay #1467

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CrimRecya
Copy link
Contributor

  • In vanilla, vehicles and infantries will only fire once in one frame, even if their ROF or BurstDelay is set to 0. Now you can force units to fire all bursts in one frame by setting the Burst.NoDelay to true (useless for buildings yet).

In rulesmd.ini:

[SOMEWEAPON]          ; WeaponType
Burst.NoDelay=false   ; boolean

Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl
Copy link
Contributor

Tested locally.

@Starkku
Copy link
Contributor

Starkku commented Jan 14, 2025

Does this play nice with DelayedFire?

@CrimRecya
Copy link
Contributor Author

CrimRecya commented Jan 15, 2025

Does this play nice with DelayedFire?

Do you mean IsAnimDelayedFire ? No, it's exclusive to buildings. @TaranDahl has done another implement that allows buildings to work like this with IsAnimDelayedFire, which is not included in this.

@Starkku
Copy link
Contributor

Starkku commented Jan 15, 2025

I was thinking of #1338 but forgot it was not merged yet

@CrimRecya
Copy link
Contributor Author

I was thinking of #1338 but forgot it was not merged yet

I looked at it briefly and felt it might not fit perfectly. I used a simple loop to call the firing function here, and DelayedFire seems to need to complete each "charge" check in the firing function, so it may only fire once in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants