[Highly Customized] Jumpjet Tilts While Moving

[CrimRecya]

• Now you can make jumpjets tilt forward when moving forward and sideways when turning by setting JumpjetTilt to true.
• The maximum tilt angle will not exceed 45 degrees.
  • The magnitude of the forward tilt is related to the current speed and acceleration. They are additive and have two coefficients that can be adjusted for details.
  • The magnitude of the sideways tilt is related to the current speed and rotation angle. They are multiplied and also have two coefficients that can be adjusted for details.

In rulesmd.ini:

[AudioVisual]
JumpjetTilt=false                       ; boolean

[SOMEUNIT]                              ; UnitType, with Locomotor=Jumpjet
JumpjetTilt=                            ; boolean, defaults to [AudioVisual]->JumpjetTilt
JumpjetTilt.ForwardAccelFactor=1.0      ; floating point value
JumpjetTilt.ForwardSpeedFactor=1.0      ; floating point value
JumpjetTilt.SidewaysRotationFactor=1.0  ; floating point value
JumpjetTilt.SidewaysSpeedFactor=1.0     ; floating point value

• In addition, fix an issue caused by Phobos:
  Ground units being lifted will turn to attacker weirdly.

[github-actions]

Nightly build for this pull request:

• compiled-dll-0a28745bfd87c821e30d23b1a78497ab1545c4f3.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Metadorius]

Looks good, few style and readability issues.

I have a few suggestions though:

1. Ability to control how much the jumpjet tilts, I imagine via separate factors for forward and sideway tilts.
2. Ability to account acceleration for directional tilt (when accelerating - tilt forwards, decelerating - tilt backwards to decelerate). This could work additionally to movement-dependant tilt.
3. Debatable: ability to account speed for rotational tilt, because static helicopter rotating via tilt looks weird, and to do sharp turns at high speed you must tilt a lot. But maybe could just remove rotation sideways tilt when not moving.

JumpjetTilt.ForwardAccelFactor  ; FAF 
JumpjetTilt.ForwardSpeedFactor  ; FSF
JumpjetTilt.SidewaysRotationFactor  ; SRF
JumpjetTilt.SidewaysSpeedFactor  ; SSF

Pseudocode to show what I mean:

arf += movement_acceleration * FAF + movement_speed * FSF
ars += rotation_speed * SRF * movement_speed * SSF

(By the way, I am not sure I understand the current sideways rotation logic correctly. What does it depend on?)

What do you think?

[Metadorius]

It would be good to have an explanation in a comment about what is the calculation logic. Also magic numbers should be fixed.

[Coronia]

If a tilting jumpjet is affected by EMP, it'll gradually resume to normal stance while being EMP'd. Not sure if it should behave like that