[Highly Customized] Jumpjet Tilts While Moving

[CrimRecya]

• Now you can make jumpjets tilt forward when moving forward and sideways when turning by setting JumpjetTilt to true.
• The maximum tilt angle will not exceed 45 degrees.
  • The magnitude of the forward tilt is related to the current speed and acceleration. They are additive and have two coefficients that can be adjusted for details.
  • The magnitude of the sideways tilt is related to the current speed and rotation angle. They are multiplied and also have two coefficients that can be adjusted for details.

In rulesmd.ini:

[SOMEUNIT]                              ; UnitType, with Locomotor=Jumpjet
JumpjetTilt=false                       ; boolean
JumpjetTilt.ForwardAccelFactor=1.0      ; floating point value
JumpjetTilt.ForwardSpeedFactor=1.0      ; floating point value
JumpjetTilt.SidewaysRotationFactor=1.0  ; floating point value
JumpjetTilt.SidewaysSpeedFactor=1.0     ; floating point value

[github-actions]

Nightly build for this pull request:

• compiled-dll-3d3fd2168825d74cf5484a1be4618a5f8ffb9a38.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Metadorius]

Looks good, few style and readability issues.

I have a few suggestions though:

1. Ability to control how much the jumpjet tilts, I imagine via separate factors for forward and sideway tilts.
2. Ability to account acceleration for directional tilt (when accelerating - tilt forwards, decelerating - tilt backwards to decelerate). This could work additionally to movement-dependant tilt.
3. Debatable: ability to account speed for rotational tilt, because static helicopter rotating via tilt looks weird, and to do sharp turns at high speed you must tilt a lot. But maybe could just remove rotation sideways tilt when not moving.

JumpjetTilt.ForwardAccelFactor  ; FAF 
JumpjetTilt.ForwardSpeedFactor  ; FSF
JumpjetTilt.SidewaysRotationFactor  ; SRF
JumpjetTilt.SidewaysSpeedFactor  ; SSF

Pseudocode to show what I mean:

arf += movement_acceleration * FAF + movement_speed * FSF
ars += rotation_speed * SRF * movement_speed * SSF

(By the way, I am not sure I understand the current sideways rotation logic correctly. What does it depend on?)

What do you think?

[Coronia]

If a tilting jumpjet is affected by EMP, it'll gradually resume to normal stance while being EMP'd. Not sure if it should behave like that

[Coronia]

maybe there's no need to set it globally since you'll still have to customize those factors for each jumpjet. Otherwise LGTM

[TaranDahl]

How about move JumpjetTilt= to [JumpjetControls] 🤔

[CrimRecya]

I imagined that perhaps there is no need for global label?
It seems that only helicopters require this function, while spacecraft may only need to tilt sideways, but this definitely requires customization. Other UFO or balloons/airships may not need this.

[Metadorius]

I can imagine some quick/nimble helicopters tilting up to 90 degrees, so it would be good to have that as the limitation instead of 45. I doubt it will hamper usability, so why not?

Otherwise I have no complaints regarding this feature. Maybe it's worth adding a GIF to the docs? I suggest to use GifCam, as it doesn't make the GIF lose the quality.

[CrimRecya]

I can imagine some quick/nimble helicopters tilting up to 90 degrees, so it would be good to have that as the limitation instead of 45. I doubt it will hamper usability, so why not?

That probably also requires modifying the shadow matrix to make it more effective. I will add it later.

[Metadorius]

That probably also requires modifying the shadow matrix to make it more effective. I will add it later.

Oh, that's a fair comment, I didn't think of that. Feel free to merge as is then, the 90 degree adjustment can be made later. The shadow drawing doesn't make a lot of sense in the vanilla game so it needs a good rewrite.