Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Disallow other actions for building in planning mode #1524

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

TaranDahl
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Minor Documentation is not required label Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Metadorius
Copy link
Member

Works good, can you also handle showing the no action map cursor instead of move/no move cursor?

@Starkku
Copy link
Contributor

Starkku commented Feb 12, 2025

I would use a more descriptive name for the hook if possible.

Copy link
Contributor

@CrimRecya CrimRecya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly Get_Stack.

src/Ext/Building/Hooks.cpp Outdated Show resolved Hide resolved
@Metadorius
Copy link
Member

Look into REF_STACK and LEA_STACK. They should be more suitable here.

@CrimRecya
Copy link
Contributor

Look into REF_STACK and LEA_STACK. They should be more suitable here.

Yes, LEA_STACK should be the most direct, but considering that neither of these functions actually changes the cell struct, both can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants