Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Add validity check for NearByLocation and fix incorrect usage of TryGetCellAt and GetCellAt #1527

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Minor] Add validity check for NearByLocation and fix incorrect usage of TryGetCellAt and GetCellAt #1527

wants to merge 1 commit into from
+27 −14

Conversation

CrimRecya
Copy link
Contributor

  • NearByLocation may return CellStruct::Empty, it should be checked.
  • TryGetCellAt and GetCellAt are being misused, I inferred the intended usage based on the code, but I am not sure if this is the original authors' idea.

@CrimRecya CrimRecya added the Minor Documentation is not required label Feb 13, 2025
@github-actions GitHub Actions
Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Minor Documentation is not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CrimRecya