Auto-round scores down to align scores & medals

src/dbt_score/formatters/human_readable_formatter.py

@@ -1,6 +1,5 @@
 """Human readable formatter."""
 
-
 from typing import Any
 
 from dbt_score.evaluation import ModelResultsType
@@ -34,9 +33,7 @@ def model_evaluated(
         """Callback when a model has been evaluated."""
         if score.value < self._config.fail_any_model_under:
             self._failed_models.append((model, score))
-        print(
-            f"{score.badge} {self.bold(model.name)} (score: {round(score.value, 1)!s})"
-        )
+        print(f"{score.badge} {self.bold(model.name)} (score: {score.human_value!s})")
         for rule, result in results.items():
             if result is None:
                 print(f"{self.indent}{self.label_ok} {rule.source()}")
@@ -51,16 +48,16 @@ def model_evaluated(
 
     def project_evaluated(self, score: Score) -> None:
         """Callback when a project has been evaluated."""
-        print(f"Project score: {self.bold(str(round(score.value, 1)))} {score.badge}")
+        print(f"Project score: {self.bold(str(score.human_value))} {score.badge}")
 
         if len(self._failed_models) > 0:
             print()
             print(
                 f"Error: model score too low, fail_any_model_under = "
                 f"{self._config.fail_any_model_under}"
             )
-            for model, score in self._failed_models:
-                print(f"Model {model.name} scored {round(score.value, 1)}")
+            for model, model_score in self._failed_models:
+                print(f"Model {model.name} scored {model_score.value}")
 
         elif score.value < self._config.fail_project_under:
             print()

src/dbt_score/scoring.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import math
 import typing
 from dataclasses import dataclass
 
@@ -19,6 +20,11 @@ class Score:
     value: float
     badge: str
 
+    @property
+    def human_value(self) -> float:
+        """Auto-round score down to 1 decimal place."""
+        return math.floor(self.value * 10) / 10
+
 
 class Scorer:
     """Logic for computing scores."""

tests/formatters/test_human_readable_formatter.py

@@ -1,6 +1,5 @@
 """Unit tests for the human readable formatter."""
 
-
 from dbt_score.evaluation import ModelResultsType
 from dbt_score.formatters.human_readable_formatter import HumanReadableFormatter
 from dbt_score.rule import RuleViolation
@@ -29,10 +28,10 @@ def test_human_readable_formatter_model(
     stdout = capsys.readouterr().out
     assert (
         stdout
-        == """🥇 \x1B[1mmodel1\x1B[0m (score: 10.0)
-    \x1B[1;32mOK  \x1B[0m tests.conftest.rule_severity_low
-    \x1B[1;31mERR \x1B[0m tests.conftest.rule_severity_medium: Oh noes
-    \x1B[1;33mWARN\x1B[0m (critical) tests.conftest.rule_severity_critical: Error
+        == """🥇 \x1b[1mmodel1\x1b[0m (score: 10.0)
+    \x1b[1;32mOK  \x1b[0m tests.conftest.rule_severity_low
+    \x1b[1;31mERR \x1b[0m tests.conftest.rule_severity_medium: Oh noes
+    \x1b[1;33mWARN\x1b[0m (critical) tests.conftest.rule_severity_critical: Error
 
 """
     )
@@ -45,7 +44,50 @@ def test_human_readable_formatter_project(capsys, default_config, manifest_loade
     )
     formatter.project_evaluated(Score(10.0, "🥇"))
     stdout = capsys.readouterr().out
-    assert stdout == "Project score: \x1B[1m10.0\x1B[0m 🥇\n"
+    assert stdout == "Project score: \x1b[1m10.0\x1b[0m 🥇\n"
+
+
+def test_human_readable_formatter_near_perfect_model_score(
+    capsys,
+    default_config,
+    manifest_loader,
+    model1,
+    rule_severity_low,
+    rule_severity_medium,
+    rule_severity_critical,
+):
+    """Ensure the formatter has the correct output after model evaluation."""
+    formatter = HumanReadableFormatter(
+        manifest_loader=manifest_loader, config=default_config
+    )
+    results: ModelResultsType = {
+        rule_severity_low: None,
+        rule_severity_medium: Exception("Oh noes"),
+        rule_severity_critical: RuleViolation("Error"),
+    }
+    formatter.model_evaluated(model1, results, Score(9.99, "🥈"))
+    stdout = capsys.readouterr().out
+    assert (
+        stdout
+        == """🥈 \x1b[1mmodel1\x1b[0m (score: 9.9)
+    \x1b[1;32mOK  \x1b[0m tests.conftest.rule_severity_low
+    \x1b[1;31mERR \x1b[0m tests.conftest.rule_severity_medium: Oh noes
+    \x1b[1;33mWARN\x1b[0m (critical) tests.conftest.rule_severity_critical: Error
+
+"""
+    )
+
+
+def test_human_readable_formatter_near_perfect_project_score(
+    capsys, default_config, manifest_loader
+):
+    """Ensure the formatter has the correct output after project evaluation."""
+    formatter = HumanReadableFormatter(
+        manifest_loader=manifest_loader, config=default_config
+    )
+    formatter.project_evaluated(Score(9.99, "🥈"))
+    stdout = capsys.readouterr().out
+    assert stdout == "Project score: \x1b[1m9.9\x1b[0m 🥈\n"
 
 
 def test_human_readable_formatter_low_model_score(
@@ -68,10 +110,10 @@ def test_human_readable_formatter_low_model_score(
     print()
     assert (
         stdout
-        == """🚧 \x1B[1mmodel1\x1B[0m (score: 0.0)
-    \x1B[1;33mWARN\x1B[0m (critical) tests.conftest.rule_severity_critical: Error
+        == """🚧 \x1b[1mmodel1\x1b[0m (score: 0.0)
+    \x1b[1;33mWARN\x1b[0m (critical) tests.conftest.rule_severity_critical: Error
 
-Project score: \x1B[1m0.0\x1B[0m 🚧
+Project score: \x1b[1m0.0\x1b[0m 🚧
 
 Error: model score too low, fail_any_model_under = 5.0
 Model model1 scored 0.0
@@ -99,10 +141,10 @@ def test_human_readable_formatter_low_project_score(
     print()
     assert (
         stdout
-        == """🥇 \x1B[1mmodel1\x1B[0m (score: 10.0)
-    \x1B[1;33mWARN\x1B[0m (critical) tests.conftest.rule_severity_critical: Error
+        == """🥇 \x1b[1mmodel1\x1b[0m (score: 10.0)
+    \x1b[1;33mWARN\x1b[0m (critical) tests.conftest.rule_severity_critical: Error
 
-Project score: \x1B[1m0.0\x1B[0m 🚧
+Project score: \x1b[1m0.0\x1b[0m 🚧
 
 Error: project score too low, fail_project_under = 5.0
 """