Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filter in rule public_model_has_example_sql #80

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

matthieucan
Copy link
Contributor

A rule should not care about public/private models, for this a RuleFilter should be used.

Copy link
Contributor

@jochemvandooren jochemvandooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@matthieucan matthieucan merged commit f8acb46 into master Oct 22, 2024
3 checks passed
@matthieucan matthieucan deleted the matthieucan/example-sql-filter branch October 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants