Mojo Solution Contribution #1003

Evan-LucasCurrie · 2025-09-04T07:09:11Z

Description

This PR contains two mojo solutions:

Following Daves approach as close as possible within the context of Mojo
Using 8 bits and slightly optimizing the calculations

Contributing requirements

I read the contribution guidelines in CONTRIBUTING.md.
I placed my solution in the correct solution folder.
I added a README.md with the right badge(s).
I added a Dockerfile that builds and runs my solution.
I selected drag-race as the target branch.
All code herein is licensed compatible with BSD-3.

Mojo Solution for contribution

adjusted formatting strings for the tags

rbergen

Thanks for your submission!

I have two minor (textual) remarks, the second of which you could even ignore - I acknowledge that is a very nit-picky one indeed.

Other than that, it looks good to me!

PrimeMojo/solution_1/README.md

As per feedback, updated.

rbergen

LGTM!

As this is a new solution in a new language, I will also ask for a review from @marghidanu.

Evan-LucasCurrie · 2025-09-04T17:25:32Z

If possible, pause on reviewing or merging this with the main branch. I reviewed it over my lunch break and it's technically not faithful. As the arrays are metaprogramming, not runtime dynamic I made this when the kids got to bed, I was tired and my dyslexia kicked in.
When I get off work I'll quickly add a faithful one and switch these to non-faithful. I don't want to misrepresent the language in the case where it's missed.

rbergen · 2025-09-04T17:42:27Z

Of course we can pause the review and merge process at any time; as far as I know all maintainers here are still human. :)

In any case, I really appreciate your transparency and proactiveness on this. I'll just wait for your next update.

Faithful implementation and cleaned up messy print method.

Evan-LucasCurrie · 2025-09-04T22:54:11Z

I updated it now, thank you for the understanding. I made some quality of life changes and showed a few different ways of approaching the solution, both through metaprogramming and dynamic allocation (faithful). Hopefully this shows off the language.

Corrected formatting and added clarity to the 8bit explanation.

rbergen

I've reviewed your solution again after your recent updates, and I found some small things that I missed before, that need to be changed for your solution to be successfully included in the automated benchmark and the reporting thereof.

rbergen · 2025-09-06T19:01:15Z

PrimeMojo/solution_1/primesieve.mojo

+    fn printResults(self: Self, duration: UInt64, passes: UInt64) -> None:
+        try:
+            var final_string = (
+                "ELucasCurrie_1bit;{0};{1};1;algorithm=base,faithful=yes,bit=1"


bit=1 should be bits=1

rbergen · 2025-09-06T19:01:24Z

PrimeMojo/solution_1/DockerFile

This file should be named Dockerfile (lower-case "f")

rbergen · 2025-09-06T19:01:51Z

PrimeMojo/solution_1/primesieve.mojo

+    fn printResults(self: Self, duration: UInt64, passes: UInt64) -> None:
+        try:
+            var final_string = (
+                "ELucasCurrie_8bit;{0};{1};1;algorithm=base,faithful=yes,bit=8"


bit=8 should be bits=8

rbergen · 2025-09-06T19:02:05Z

PrimeMojo/solution_1/primesieve.mojo

+    fn printResults(self: Self, duration: UInt64, passes: UInt64) -> None:
+        try:
+            var final_string = (
+                "ELucasCurrie_1bit;{0};{1};1;algorithm=base,faithful=no,bit=1"


bit=1 should be bits=1

rbergen · 2025-09-06T19:02:23Z

PrimeMojo/solution_1/primesieve.mojo

+    fn printResults(self: Self, duration: UInt64, passes: UInt64) -> None:
+        try:
+            var final_string = (
+                "ELucasCurrie_8bit;{0};{1};1;algorithm=base,faithful=no,bit=8"


bit=8 should be bits=8

Updated strings to print bits rather than bit

Updated the case for the docker file

Modified the readme to reflect the changes made.

Evan-LucasCurrie · 2025-09-06T19:21:02Z

Thank you, for looking at it again and I made the changes so it should be successful for the automation now. Also apologies for making you have to look that close into it.

rbergen · 2025-09-06T19:22:50Z

No worries. I actually took a closer look because I found I overlooked some similar things in #998, quite recently.

Thanks for following up so quickly!

rbergen · 2025-09-06T19:33:34Z

There is actually one more thing: the meta and non-meta implementations use the same labels in their output lines, which confuses the benchmark reporting. You could add "_meta" to the meta implementation variations' output labels to make the distinction between the two approaches apparent in the benchmark results.

Updated identifier & Readme

Evan-LucasCurrie · 2025-09-06T20:06:43Z

Yeah no problem, and I modified it to now correctly show the identifiers. I might have factored it out by accident when making the interface. Hopefully, all is well now :) but feel free to reach out again if there are any issues, I'll address them as soon as I can. Thank you for being so understanding!

rbergen

LGTM, again.

Mojo bool is actually a structure, thus not a true 8 bit. Mojo also does bounds checking by default when indexing into an array. Modified to unsafe get.

Evan-LucasCurrie · 2025-09-07T01:15:10Z

Sorry, but I have to add one primary change specifically here in the documentation: Mojo BitSet Docs

It mentions bools use 64x more memory which made me look into it and they are structures even though it says primitive scalar values. Meaning they use the full address space, this is a kind of language gotcha I didn't know about. However, I updated it to UInt8 and made a small optimization for indexing since I had to make this commit.

marghidanu · 2025-09-07T13:49:41Z

I was waiting for this for some time, glad to see a solution in Mojo!

LGTM

rbergen · 2025-09-07T14:46:33Z

@Evan-LucasCurrie I'm just asking because you've been updating this solution over the past few days: are we good to merge, as far as you're concerned?

Evan-LucasCurrie · 2025-09-07T15:11:26Z

@rbergen Yeah, it's in a good place to merge. There is for sure performance on the table but that's always the case. I'm sure either myself or someone in the mojo community will eventually improve upon it.

Much thanks, honestly you all made this process super pleasant and I appreciate it!

rbergen · 2025-09-07T15:38:57Z

Alright, that's great! If CI passes I'll merge, then.

And thank you for the kind words!

Evan-LucasCurrie added 4 commits September 4, 2025 01:45

Mojo Solution

bd27a84

Mojo Solution for contribution

fixed formatting

318edf9

adjusted formatting strings for the tags

Update output format in README.md

5412375

Enhance README with algorithm and performance badges

d1e8840

rbergen reviewed Sep 4, 2025

View reviewed changes

PrimeMojo/solution_1/README.md Show resolved Hide resolved

PrimeMojo/solution_1/README.md Outdated Show resolved Hide resolved

Update README.md

d737b8a

As per feedback, updated.

rbergen approved these changes Sep 4, 2025

View reviewed changes

rbergen requested a review from marghidanu September 4, 2025 14:53

Faithful Implementations

4ae1cab

Faithful implementation and cleaned up messy print method.

Update README.md for clarity and formatting

80b19b3

Corrected formatting and added clarity to the 8bit explanation.

rbergen requested changes Sep 6, 2025

View reviewed changes

Evan-LucasCurrie added 3 commits September 6, 2025 14:11

update bit to bits

bcb1ec7

Updated strings to print bits rather than bit

Lowercase F Dockerfile

c35df85

Updated the case for the docker file

Update readme

a39aded

Modified the readme to reflect the changes made.

Update identifier

0dbef14

Updated identifier & Readme

rbergen approved these changes Sep 6, 2025

View reviewed changes

True 8 bit

ce75648

Mojo bool is actually a structure, thus not a true 8 bit. Mojo also does bounds checking by default when indexing into an array. Modified to unsafe get.

rbergen merged commit 80bcfcf into PlummersSoftwareLLC:drag-race Sep 7, 2025
172 checks passed

Mojo Solution Contribution #1003

Mojo Solution Contribution #1003

Uh oh!

Conversation

Evan-LucasCurrie commented Sep 4, 2025

Description

Contributing requirements

Uh oh!

rbergen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rbergen left a comment

Choose a reason for hiding this comment

Uh oh!

Evan-LucasCurrie commented Sep 4, 2025

Uh oh!

rbergen commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Evan-LucasCurrie commented Sep 4, 2025

Uh oh!

rbergen left a comment

Choose a reason for hiding this comment

Uh oh!

rbergen Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

rbergen Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

rbergen Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

rbergen Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

rbergen Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

Evan-LucasCurrie commented Sep 6, 2025

Uh oh!

rbergen commented Sep 6, 2025

Uh oh!

rbergen commented Sep 6, 2025

Uh oh!

Evan-LucasCurrie commented Sep 6, 2025

Uh oh!

rbergen left a comment

Choose a reason for hiding this comment

Uh oh!

Evan-LucasCurrie commented Sep 7, 2025

Uh oh!

marghidanu commented Sep 7, 2025

Uh oh!

rbergen commented Sep 7, 2025

Uh oh!

Evan-LucasCurrie commented Sep 7, 2025

Uh oh!

rbergen commented Sep 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rbergen commented Sep 4, 2025 •

edited

Loading