This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
feat: allow specified public query var values to be exposed in apollo studio #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpetto
requested review from
efixler and
kschelonka
and removed request for
a team
jpetto
force-pushed
the
MC-422-unmask-query-variables
branch
from
1b718c8 to
30d613f
Compare
jpetto
force-pushed
the
MC-422-unmask-query-variables
branch
from
30d613f to
920588f
Compare
|
While i think this will work, I think it will double report, because the federated gateway is already sending this telemetry to apollo studio I think you need https://www.apollographql.com/docs/router/configuration/telemetry/apollo-telemetry/#send_variable_values added to https://github.com/Pocket/pocket-monorepo/blob/main/servers/client-api/config/router.yaml |
|
closing in favor of Pocket/pocket-monorepo#76 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
allow specified query var values to be displayed in apollo studio (to aid in debugging).
Tickets
Implementation Decisions
decided to do an allow list instead of allowing all for future-proofing against displaying potentially sensitive query vars.