Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unused listen discoverability experiment #181

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

marcin-kozinski
Copy link
Collaborator

Had this one on my list for a long time. We turned off the tooltips a long time ago. Then in the rewrites we dropped calls to the turned off methods. Recently I cleaned up some Alpha Settings related to this.

But until today we never cleaned up all this dead code that was left.

References

PR Checklist

Setup:

  • Described changes for automated release notes in PR title using
    Conventional Commits standard
  • Self Review (review, clean up, documentation)
  • Basic Self QA

Review:

  • Code Review approved

@marcin-kozinski marcin-kozinski force-pushed the clean-up-listen-discoverability branch from 2b04553 to f6c23e7 Compare February 5, 2025 15:04
…scoverability (#184)

* File Pocket/src/main/res/values/strings.xml was updated on es-LA locale

* File Pocket/src/main/res/values/strings.xml was updated on it-IT locale

* File Pocket/src/main/res/values/strings.xml was updated on pl-PL locale

* File Pocket/src/main/res/values/strings.xml was updated on fr-CA locale

* File Pocket/src/main/res/values/strings.xml was updated on ru-RU locale

* File Pocket/src/main/res/values/strings.xml was updated on nl-NL locale

* File Pocket/src/main/res/values/strings.xml was updated on pt-PT locale

* File Pocket/src/main/res/values/strings.xml was updated on pt-BR locale

* File Pocket/src/main/res/values/strings.xml was updated on es-ES locale

* File Pocket/src/main/res/values/strings.xml was updated on zh-CN locale

* File Pocket/src/main/res/values/strings.xml was updated on fr-FR locale

* File Pocket/src/main/res/values/strings.xml was updated on ja-JP locale

* File Pocket/src/main/res/values/strings.xml was updated on de-DE locale

* File Pocket/src/main/res/values/strings.xml was updated on ko-KR locale

* File Pocket/src/main/res/values/strings.xml was updated on zh-TW locale

---------

Co-authored-by: smartling-github-connector[bot] <165276057+smartling-github-connector[bot]@users.noreply.github.com>
@marcin-kozinski marcin-kozinski force-pushed the clean-up-listen-discoverability branch from d40de3a to 978f560 Compare February 5, 2025 15:16
@marcin-kozinski marcin-kozinski added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 3d1fe1b Feb 5, 2025
4 checks passed
@marcin-kozinski marcin-kozinski deleted the clean-up-listen-discoverability branch February 5, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant