-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sectiontext qtype should not support feedback #503
Sectiontext qtype should not support feedback #503
Conversation
* Removing illegal console commands. Script may not be needed. * Fixing illegal line length. * Fixing docblocks and unused variables. * Fixing css spaces. * Adding a true return. * Fixing JSON context.
Co-authored-by: Emanoil Manoylov <[email protected]>
Signed-off-by: Joseph Rézeau <[email protected]>
OOps! Just noticed that my PR contains changes in 2 files, which was not intended but does fix 2 issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you rebase/reapply against MOODLE_401_STABLE and resubmit?
Signed-off-by: rezeau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
I rebased and created a new pull request. Closing this one. |
Aha. Just found #514 |
Signed-off-by: rezeau <[email protected]>
Signed-off-by: rezeau <[email protected]>
No description provided.