Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sectiontext qtype should not support feedback #503

Conversation

rezeau
Copy link
Contributor

@rezeau rezeau commented Aug 10, 2023

No description provided.

FelixDiLenarda and others added 5 commits May 16, 2023 14:13
* Removing illegal console commands. Script may not be needed.

* Fixing illegal line length.

* Fixing docblocks and unused variables.

* Fixing css spaces.

* Adding a true return.

* Fixing JSON context.
@rezeau
Copy link
Contributor Author

rezeau commented Aug 10, 2023

OOps! Just noticed that my PR contains changes in 2 files, which was not intended but does fix 2 issues:

  1. In classes/question/sectiontext.php; sectiontext qtype (label) should not support feedback
  2. in tests/behat/no_feedback_question_types.feature: current navigation to Advanced settings and check that I should not see "Feedback options" does not work as expected. This should be fixed by my PR.

@mchurchward mchurchward changed the base branch from MOODLE_400_STABLE to MOODLE_401_STABLE September 18, 2023 11:09
@mchurchward mchurchward changed the base branch from MOODLE_401_STABLE to MOODLE_400_STABLE September 18, 2023 11:09
Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you rebase/reapply against MOODLE_401_STABLE and resubmit?

rezeau added a commit to rezeau/moodle-mod_questionnaire that referenced this pull request Oct 2, 2023
@rezeau rezeau requested a review from mchurchward October 6, 2023 17:10
@mchurchward mchurchward changed the base branch from MOODLE_400_STABLE to MOODLE_401_STABLE February 23, 2024 16:09
Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@mchurchward
Copy link
Contributor

I rebased and created a new pull request. Closing this one.

@mchurchward
Copy link
Contributor

Aha. Just found #514

mchurchward pushed a commit that referenced this pull request Feb 23, 2024
lucaboesch pushed a commit to lucaboesch/moodle-mod_questionnaire that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants