-
Notifications
You must be signed in to change notification settings - Fork 52
size down the code base #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @zhenfeizhang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant codebase reduction by systematically removing several Polynomial Commitment Schemes and their underlying infrastructure. The changes aim to streamline the project by eliminating unused components and simplifying existing ones, while also updating the system to support future PCS additions.
Highlights
- Polynomial Commitment Scheme (PCS) Cleanup: I have completely removed the
OrionandHyraxPolynomial Commitment Schemes from the codebase, including their implementations, configurations, and all associated tests. This significantly reduces the overall code footprint. - KZG Scheme Simplification: The
BiKZG(Bivariate KZG) scheme has been replaced withUniKZG(Univariate KZG). This involved deleting allBiKZG-specific code and streamlining theUniKZGimplementation by removing now-unused structures likeHyperKZGAggregatedEvals. - Dependency Pruning: The
treecrate, along with its entire directory, has been removed as it is no longer a dependency. Additionally,gf2,serdes_derive, andconfig_macroshave been pruned from the workspace and relevant files where their functionality is no longer needed. - PCS Type Evolution: The
PolynomialCommitmentTypeenum has been updated to reflect the removal of deprecated PCS types (Hyrax,Orion,FRI) and to introduceWHIR, paving the way for future PCS integrations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to reduce the codebase size by removing several cryptographic schemes, including Orion, Hyrax, and BiKZG. The changes primarily consist of deleting files and code related to these schemes, which is consistent with the PR's goal. My review has identified one critical issue in the root Cargo.toml where the config_macros crate is removed from the workspace members, which will likely break the build as it is still in use. This needs to be addressed to ensure the project compiles successfully.
| "arith/polynomials", | ||
| "bin", # binary executables | ||
| "circuit", | ||
| "config_macros", # proc macros used to declare a new config, this has to a separate crate due to rust compilation issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config_macros crate is removed from the workspace members, but it appears to be still in use in other parts of the codebase (e.g., in gkr/src/gkr_configs.rs). This will likely cause the build to fail because path dependencies to non-workspace members are not resolved correctly. Please consider re-adding config_macros to the workspace members.
A similar issue might exist for serdes_derive (removed on line 18) if it's still in use.
Uh oh!
There was an error while loading. Please reload this page.