-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use translate3d and scale3d for better performance on iOS #119
Conversation
Please merge - It'd be nice to have this upstream. This PR doesn't change the look and feel of any of the animations. It just makes them perform better (like day and night on iOS!). |
Thanks for the PR. cc @cdata @notwaldorf |
@MajorBreakfast, I was wondering - is there quantitative data on this? What version of Safari are you running? I will think modern browsers optimize this for you - I'd be surprised if Safari doesn't use GPU for both. For me, animations run quite smoothly as it is now (I'm using 9.0.2 btw). I don't have any data though - I did however make super-quick cut-and-paste seat-of-the-pants bins: 500 moving stars! 500 moving stars! Try opening both using Safari... Is there a difference for you? |
@zerodevx No I don't have any data on this. But it's an old trick. The internet is littered with articles about this. Also it's clearly noticable on our iPad Pro. Can you add some scaling into the mix? My supsicion is that it might also have something to do with text rendering. https://www.smashingmagazine.com/2012/06/play-with-hardware-accelerated-css/ @ebidel I think you're coming close to getting the award for slowest to merge open source project I've contributed to oO. |
The team are sorry for the delay on reviewing this change, @MajorBreakfast. Just started helping out with this element. The CSS Safari supports |
+1 to @addyosmani. @MajorBreakfast do you mind updating this PR? |
I think we should just do this directly in the polyfill. Filed web-animations/web-animations-next#449 |
I am experiencing bad performance on iOS with the current version. With this change everything becomes buttery smooth.