Optimize number helper

Portalum · Sep 20, 2024 · f3610ee · f3610ee
1 parent f7e5607
commit f3610ee
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/src/Portalum.Zvt.UnitTest/NumberHelperTest.cs b/src/Portalum.Zvt.UnitTest/NumberHelperTest.cs
@@ -8,6 +8,22 @@ namespace Portalum.Zvt.UnitTest
     [TestClass]
     public class NumberHelperTest
     {
+        [TestMethod]
+        public void DecimalToBcd_Convert()
+        {
+            var amount = 0M;
+
+            for (var i = 0M; i < 100; i += 0.01M)
+            {
+                amount += i;
+
+                var bcdBytes = NumberHelper.DecimalToBcd(amount);
+                var newAmount = NumberHelper.BcdToDecimal(bcdBytes);
+
+                Assert.AreEqual(amount, newAmount);
+            }
+        }
+
         [TestMethod]
         public void DecimalToBcd_CommercialRoundOff_Successful()
         {

diff --git a/src/Portalum.Zvt/Helpers/NumberHelper.cs b/src/Portalum.Zvt/Helpers/NumberHelper.cs
@@ -50,6 +50,32 @@ public static byte[] DecimalToBcd(decimal value, int length = 6)
             return data.Reverse().ToArray();
         }
 
+        /// <summary>
+        /// Convert Binary Coded Decimal to decimal
+        /// </summary>
+        /// <param name="bcdBytes"></param>
+        /// <returns></returns>
+        public static decimal BcdToDecimal(byte[] bcdBytes)
+        {
+            long result = 0;
+
+            foreach (var bcdByte in bcdBytes)
+            {
+                var highNibble = (bcdByte >> 4) & 0xF;
+                var lowNibble = bcdByte & 0xF;
+
+                if (highNibble > 9 || lowNibble > 9)
+                {
+                    throw new ArgumentException("Invalid BCD-Format");
+                }
+
+                result = result * 10 + highNibble;
+                result = result * 10 + lowNibble;
+            }
+
+            return result / 100m;
+        }
+
         /// <summary>
         /// Convert int to Binary Coded Decimal
         /// </summary>