Skip to content

Commit

Permalink
Fix unittest and docs for tap_size
Browse files Browse the repository at this point in the history
Signed-off-by: Bram Stoeller <[email protected]>
  • Loading branch information
bramstoeller committed Jul 13, 2022
1 parent 322bfd8 commit eb123be
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/graph-data-model.md
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ In this case the winding voltage is decreased if the tap position is increased.*
| `tap_min` | `int8_t` | - | position of tap changer at minimum voltage | &#10004; | &#10004; | &#10060; | &#10060; | |
| `tap_max` | `int8_t` | - | position of tap changer at maximum voltage | &#10004; | &#10004; | &#10060; | &#10060; | |
| `tap_nom` | `int8_t` | - | nominal position of tap changer | &#10060; default zero | &#10004; | &#10060; | &#10060; | `(tap_min <= tap_nom <= tap_max)` or `(tap_min >= tap_nom >= tap_max)` |
| `tap_size` | `double` | volt (V) | size of each tap of the tap changer | &#10004; | &#10004; | &#10060; | &#10060; | `> 0` |
| `tap_size` | `double` | volt (V) | size of each tap of the tap changer | &#10004; | &#10004; | &#10060; | &#10060; | `>= 0` |
| `uk_min` | `double` | - | relative short circuit voltage at minimum tap | &#10060; default same as `uk` | &#10004; | &#10060; | &#10060; | `>= pk_min / sn` and `> 0` and `< 1` |
| `uk_max` | `double` | - | relative short circuit voltage at maximum tap | &#10060; default same as `uk` | &#10004; | &#10060; | &#10060; | `>= pk_max / sn` and `> 0` and `< 1` |
| `pk_min` | `double` | watt (W) | short circuit (copper) loss at minimum tap | &#10060; default same as `pk` | &#10004; | &#10060; | &#10060; | `>= 0` |
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/validation/test_input_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def test_validate_input_data_sym_calculation(input_data):
assert NotBetweenOrAtError("transformer", "clock", [1, 14], (0, 12)) in validation_errors
assert NotBetweenOrAtError("transformer", "tap_pos", [14, 15], ("tap_min", "tap_max")) in validation_errors
assert NotBetweenOrAtError("transformer", "tap_nom", [1, 15], ("tap_min", "tap_max")) in validation_errors
assert NotGreaterThanError("transformer", "tap_size", [14, 15], 0) in validation_errors
assert NotGreaterOrEqualError("transformer", "tap_size", [15], 0) in validation_errors
assert NotGreaterOrEqualError("transformer", "uk_min", [1], "pk_min/sn") in validation_errors
assert NotBetweenError("transformer", "uk_min", [14], (0, 1)) in validation_errors
assert NotGreaterOrEqualError("transformer", "uk_max", [1], "pk_max/sn") in validation_errors
Expand Down

0 comments on commit eb123be

Please sign in to comment.