Skip to content

Feature: support multi-dimensional batch calculation, chaining approach [experimental] #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft

Feature: support multi-dimensional batch calculation, chaining approach [experimental] #1201

wants to merge 43 commits into from

Conversation

@TonyXiang8787
Copy link
Member

@TonyXiang8787 TonyXiang8787 commented Nov 25, 2025

Relates to #1186

A alternative chaining approach. The adjustment on C-API is much smaller. Only introducint one additional symbol.

@TonyXiang8787
start slice dataset
8085e5b 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
add slice scenario
73d85c5 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
Merge branch 'main' into experimental/multi-dimension-batch
234f38d
@TonyXiang8787
batch dimension
be44d80 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
calculation implementation
1fd7ed3 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
error handling still needs to be done
45f4d72 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
error handling
06cb330 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
add batch dimensions
a4fc01e 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
batch dimension
118655f 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
start test
3b41f28 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
start test
d88db97 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
api will not work as intended
1b1190d 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
api will not work as intended
21c31c5 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
adjust md dataset
6e8c081 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
add dataset
0b989b4 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
crash yet
14b4039 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
fix bounds checking
3338881 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
remove span
01c86a9 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
fix clang tidy
7786b0c 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
format|
5a3f394 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
[skip ci] add cfunc in python
2650968 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
force nullptr
9aaa6bd 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
add options
e4aa439 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
proxy for multidimensional in python
237681f 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
modify main calculate input
b602f2e 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
type annotation
3e79237 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
[skip ci] not working yet
8d8d80c 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
fix dimensions
61cfd57 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
fix mypy
a1331ba 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
Merge branch 'main' into experimental/multi-dimension-batch
36707d9
@TonyXiang8787
empty slice
9c27e6e 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
Merge branch 'main' into experimental/multi-dimension-batch
bce908e
@TonyXiang8787
begin next
7faa6c1 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
revert api change
c4b854e 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
model calculate for chaining
cb67ae3 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
add dataset chaining
a7352f2 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
revert cpp interface
b3c8901 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
c-api ready
fa6fdf9 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
revert python side
65888cd 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
adjust python chaining
61e915f 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
python side ready
fb22a70 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787 TonyXiang8787 added feature New feature or request do-not-merge This should not be merged labels Nov 25, 2025
@TonyXiang8787
Copy link
Member Author

TonyXiang8787 commented Nov 25, 2025

@mgovers this is the alternative chaining approach compared to #1186. The API is much cleaner.

@TonyXiang8787
fix format
79936a6 
Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
fix format
2e0ff73 
Signed-off-by: Tony Xiang <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge This should not be merged feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TonyXiang8787