Concurrent installation#1950
Open
alerickson wants to merge 83 commits intomasterfrom
Open
Conversation
…into concurrentInstall
alerickson
requested review from
SydneyhSmith,
adityapatwardhan,
anamnavi and
shammu1
as code owners
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adityapatwardhan
requested changes
Apr 29, 2026
| { | ||
| foundPkgVersion | ||
| }; | ||
| _packagesFound.TryUpdate(foundPkgName, newPkgVersions, pkgVersions); |
Member
There was a problem hiding this comment.
Suggested change
| _packagesFound.TryUpdate(foundPkgName, newPkgVersions, pkgVersions); | |
| _packagesFound.TryUpdate(foundPkgName, newPkgVersions, pkgVersions); |
Comment on lines
+1117
to
+1124
| _packagesFound.TryUpdate(foundPkgName, newPkgVersions, pkgVersions); | ||
|
|
||
| addedToHash = true; | ||
| } | ||
| } | ||
| else | ||
| { | ||
| _packagesFound.Add(foundPkg.Name, new List<string> { foundPkgVersion }); | ||
| _packagesFound.TryAdd(foundPkg.Name, new List<string> { foundPkgVersion }); |
Member
There was a problem hiding this comment.
Can these to operations of TryAdd and TryUpdate be replaced by AddOrUpdate?
Comment on lines
+1138
to
+1147
| if (_knownLatestPkgVersion.ContainsKey(foundPkgName)) | ||
| { | ||
| _knownLatestPkgVersion.TryGetValue(foundPkgName, out PSResourceInfo oldPkgVersion); | ||
| _knownLatestPkgVersion.TryUpdate(foundPkgName, foundPkg, oldPkgVersion); | ||
| addedToHash = true; | ||
| } | ||
| else | ||
| { | ||
| _knownLatestPkgVersion.TryAdd(foundPkg.Name, foundPkg); | ||
| addedToHash = true; |
| debugMsgs.Enqueue($"Finding dependency '{dep.Name}' version range '{dep.VersionRange}'"); | ||
| FindDependencyPackageVersion(dep, currentServer, currentResponseUtil, currentPkg, repository, errorMsgs, warningMsgs, debugMsgs, verboseMsgs); | ||
| }); | ||
| // TODO: what is perf if parallel.ForEach is always run? |
| // depPkgsFound creates a new instance of depPkgsFound each time FindDependencyPackages() is called. | ||
| // This will eventually return the PSResourceInfo object to the main cmdlet class. | ||
| debugMsgs.Enqueue($"Adding'{key}' to list of dependency packages found"); | ||
| depPkgsFound.TryAdd(key, depPkg); |
Member
There was a problem hiding this comment.
TryAdd adds if not exist. Maybe dont need to check if it contains it before a TryAdd
| { | ||
| _cmdletPassedIn.WriteDebug("In V3ServerAPICalls::InstallVersion()"); | ||
| // TODO: pass in ConcurrentQueue to write out debug message. | ||
| //_cmdletPassedIn.WriteDebug("In V3ServerAPICalls::InstallVersion()"); |
| # } | ||
|
|
||
| It "find all resources with specified tag given Tag property, with and without Prerelease property" { | ||
| It "find all resources with specified tag given Tag property, with and without Prerelease property" { |
Member
There was a problem hiding this comment.
Suggested change
| It "find all resources with specified tag given Tag property, with and without Prerelease property" { | |
| It "find all resources with specified tag given Tag property, with and without Prerelease property" { |
|
|
||
| $res.Name | Should -Be $testModuleName | ||
| } | ||
|
|
| /// </summary> | ||
| public override async Task<FindResults> FindNameAsync(string packageName, bool includePrerelease, ResourceType type, ConcurrentQueue<ErrorRecord> errorMsgs, ConcurrentQueue<string> warningMsgs, ConcurrentQueue<string> debugMsgs, ConcurrentQueue<string> verboseMsgs) | ||
| { | ||
| // TODO: pass all debug output into a list that can be written to console later. |
| { | ||
| // Add pkg info to hashtable. | ||
| updatedPackagesHash.Add(pkgName, new Hashtable(StringComparer.InvariantCultureIgnoreCase) | ||
| updatedPackagesHash.TryAdd(pkgName, new Hashtable(StringComparer.InvariantCultureIgnoreCase) |
Member
There was a problem hiding this comment.
Consider removing checks for contains before TryAdd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR introduces concurrent (parallel) execution for package find/install workflows in PSResourceGet, shifting portions of the implementation to async + thread-safe data structures so multiple package operations can run at the same time.
High level, it’s aimed at improving performance and throughput when users install or query multiple resources in a single invocation by allowing work to be performed concurrently rather than strictly synchronously.
PR Context
Installing (or resolving) many packages sequentially can be slow, especially when many packages are requested, multiple repositories are queried, or network-bound operations dominate runtime.
To support concurrency safely, the PR also updates internal state handling (caches / hashes) to be thread-safe, preventing race conditions and corruption when multiple tasks update shared structures during parallel execution.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.