Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NY, moved DC, added outlying areas AS, GU, MP and UM. #15

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

rickygzz
Copy link
Contributor

Questions Answers
Description? Read below.
Fixed ticket? Fixes #14 (part of it, more PR's are coming :)

Updated <states> tag according to ISO 3166-2 (https://www.iso.org/obp/ui/#iso:code:3166:US).

  • Deleted one empty line.

  • Moved District of Columbia alphabetically ordered.

  • Added state New York "NY"

  • Added outlying areas
    -- America Samoa "AS"
    -- Guam "GU"
    -- Northern Mariana Islands "MP"
    -- United States Minor Outlying Islands "UM"

Copy link
Contributor

@Julievrz Julievrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the ISO codes present in this file match the ones in https://github.com/PrestaShop/PrestaShop/blob/develop/install-dev/data/xml/state.xml

Regarding the new states, I've checked the ISO codes on https://www.iso.org/obp/ui/#search and there are all correct.

Thanks

@PierreRambaud PierreRambaud merged commit 95aefd1 into PrestaShop:master Dec 24, 2021
@PierreRambaud
Copy link
Contributor

Thank you @rickygzz and @Julievrz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add states to North America, Central America and South America
3 participants