Added states to ar.xml according to ISO 3166-2. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julievrz
reviewed
Dec 24, 2021
There was a problem hiding this comment.
All ISO codes in this file match the ones on https://github.com/PrestaShop/PrestaShop/blob/develop/install-dev/data/xml/state.xml. I only have a doubt regarding "Ciudad de Buenos Aires". I left a comment.
rickygzz
force-pushed
the
rickygzz-patch-ar-xml
branch
from
0cadfe7 to
c61b8a5
Compare
Progi1984
approved these changes
Apr 25, 2022
sLorenzini
approved these changes
May 10, 2022
There was a problem hiding this comment.
hello @rickygzz,
Tested on develop and 178x branches
7.2.21 PHP version
- Add fix on ar.xml file in mystore folder > localization
- Go to locations > states > filter by country "Argentina"
- Deleted all states of Argentina
- Go to Localization > Select Argentina
- Choose "states" in content to import
- Set to "No" the "Download pack data" switch button (if set to yes not working, the states list of Argentina doesn't exist on prestashop.com)
- Click on Import button
- Go back to locations > states and update the page, all states on the list are displayed
QA approved ✅
Thank you
sLorenzini
added
QA ✔️
|
Thanks @rickygzz & @sLorenzini |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added <states> tag according to ISO 3166-2 (https://www.iso.org/obp/ui/#iso:code:3166:AR).