Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added local accents to states (departments) in co.xml according to ISO 3166-2 #19

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

rickygzz
Copy link
Contributor

@rickygzz rickygzz commented Dec 19, 2021

Questions Answers
Description? Read below.
Fixed ticket? Fixes #14 (part of it, more PR's are coming :)

Modified <states> tag according to ISO 3166-2 (https://www.iso.org/obp/ui/#iso:code:3166:CO).

Double checked names and ISO codes, everything looked almost fine. They were only missing accents.

Copy link
Contributor

@Julievrz Julievrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ISO codes that were added to this file are correct, according to https://www.iso.org/obp/ui/fr/#iso:code:3166:CO

I just don't understand why the old ones, already present in the co.xml file. For example, "Amazonas" don't appear in the state.xml file? @eternoendless, is it normal?

@rickygzz
Copy link
Contributor Author

State.xml file is used when installing PrestaShop for the first time.

It creates a few entries for countries' states inside <prefix>_states database table. Not all countries are present.

In the other hand, the files in LocalizationFiles, are used when the user manually pulls data from the BackOffice.

You can see that, state.xml has all states for Mexico, but mx.xml localization has NO states at all (which will be fixed soon in other pull request). When you install prestashop, all MX states are mounted into the database.

(Also the iso codes for MX used in states.xml are outdated and will be updated soon in another PR)

Soon I will PR a fix into state.xml for colombia and other countries.

@eternoendless eternoendless changed the title Added local accents to states (departments) in co.xml according to IS… Added local accents to states (departments) in co.xml according to ISO 3166-2 Jan 20, 2023
@eternoendless
Copy link
Member

Thank you @rickygzz, sorry for the long delay

@eternoendless eternoendless merged commit d2bb6da into PrestaShop:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add states to North America, Central America and South America
4 participants