Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added states in ve.xml according to ISO 3166-2 and updated distance u… #24

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

rickygzz
Copy link
Contributor

…nits to metric system.

Questions Answers
Description? Please read below.
Fixed ticket? Fixes #14 (part of it, more PR's are coming :)

Added <states> tag according to ISO 3166-2 (https://www.iso.org/obp/ui/#iso:code:3166:VE).

Also updated distance units to metric system. (Metric system was adopted in 1922 in Venezuela and it was obligatory in 1960 https://es.wikipedia.org/wiki/Sistema_Internacional_de_Unidades)

Copy link
Contributor

@Julievrz Julievrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ISO codes are correct according to the following website: https://www.iso.org/obp/ui/#iso:code:3166:VE
I also double-checked on the internet and Venezuela indeed uses the international system of units. Thanks :)

@PierreRambaud PierreRambaud merged commit 789c52c into PrestaShop:master Dec 24, 2021
@PierreRambaud
Copy link
Contributor

Thank you @rickygzz and @Julievrz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add states to North America, Central America and South America
3 participants