Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated states (provinces) in cr.xml, missing accents wrong ISO codes… #26

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

rickygzz
Copy link
Contributor

… according to ISO 3166-2.

Questions Answers
Description? Please read below.
Fixed ticket? Fixes #14 (part of it, more PR's are coming :)

Updated ISO codes according to ISO 3166-2 (https://www.iso.org/obp/ui/#iso:code:3166:CR), also added missing accents.

Additionally, for standarization purposes compared with the other xml files, the <states> tag was moved just after the </taxes> tag. Also, the country attribute was moved before the zones attribute.

Copy link
Contributor

@Julievrz Julievrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO codes are ok, thanks.

@kpodemski kpodemski merged commit 1c3d4ec into PrestaShop:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add states to North America, Central America and South America
4 participants