Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating guest accounts from back office #37211

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

kpodemski
Copy link
Contributor

@kpodemski kpodemski commented Oct 22, 2024

Questions Answers
Branch? 9.0.x
Description? It was impossible to create a guest account from the back office
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Try to create a guest account from the back office before and after this change
UI Tests https://github.com/kpodemski/ga.tests.ui.pr/actions/runs/11455516404
Fixed issue or discussion? n/a
Related PRs n/a
Sponsor company n/a

@kpodemski kpodemski requested a review from a team as a code owner October 22, 2024 07:40
@ps-jarvis
Copy link

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

(Note: this is an automated message, but answering it will reach a real human)

@ps-jarvis ps-jarvis added the Bug fix Type: Bug fix label Oct 22, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 31, 2024
@ShaiMagal ShaiMagal added this to the 9.0.0 milestone Oct 31, 2024
@Hlavtox
Copy link
Contributor

Hlavtox commented Oct 31, 2024

Just tested it and it works properly. :-)

@florine2623 I will allow myself to merge it. It's a tiny fix and it was me who reported it to Krystian on Slack. It was broken on my install before and now successfully fixed. Don't kill me. :-)))

@Hlavtox Hlavtox added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 31, 2024
@Hlavtox Hlavtox merged commit 8ab8a3a into PrestaShop:9.0.x Oct 31, 2024
44 checks passed
@Hlavtox
Copy link
Contributor

Hlavtox commented Oct 31, 2024

@nesrineabdmouleh @Progi1984 Guys could you please create and automated test what would create and edit a guest customer? This issue fixed here was not caught here by any automated test.

I created tests for all of the commands, but the issue here was on controller level.

Snímek obrazovky 2024-10-31 093220

@Progi1984
Copy link
Member

@Hlavtox Hi, you can suggest a new scenario : https://github.com/PrestaShop/test-scenarios/issues/new?template=1_scenario.yml

You have a lot of examples here :

https://build.prestashop-project.org/test-scenarios/

It will be reviewed by @PrestaShop/qa-functional team, and automatized by us.

Thanks

@Hlavtox
Copy link
Contributor

Hlavtox commented Oct 31, 2024

@Progi1984 Thank you, I created it somehow, please modify to your liking. :-)

PrestaShop/test-scenarios#565
PrestaShop/test-scenarios#564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants