-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creating guest accounts from back office #37211
Conversation
kpodemski
commented
Oct 22, 2024
•
edited
Loading
edited
Questions | Answers |
---|---|
Branch? | 9.0.x |
Description? | It was impossible to create a guest account from the back office |
Type? | bug fix |
Category? | BO |
BC breaks? | no |
Deprecations? | no |
How to test? | Try to create a guest account from the back office before and after this change |
UI Tests | https://github.com/kpodemski/ga.tests.ui.pr/actions/runs/11455516404 |
Fixed issue or discussion? | n/a |
Related PRs | n/a |
Sponsor company | n/a |
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! (Note: this is an automated message, but answering it will reach a real human) |
Just tested it and it works properly. :-) @florine2623 I will allow myself to merge it. It's a tiny fix and it was me who reported it to Krystian on Slack. It was broken on my install before and now successfully fixed. Don't kill me. :-))) |
@nesrineabdmouleh @Progi1984 Guys could you please create and automated test what would create and edit a guest customer? This issue fixed here was not caught here by any automated test. I created tests for all of the commands, but the issue here was on controller level. |
@Hlavtox Hi, you can suggest a new scenario : https://github.com/PrestaShop/test-scenarios/issues/new?template=1_scenario.yml You have a lot of examples here : https://build.prestashop-project.org/test-scenarios/ It will be reviewed by @PrestaShop/qa-functional team, and automatized by us. Thanks |
@Progi1984 Thank you, I created it somehow, please modify to your liking. :-) |