Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new column type to the cart_rule table and index it #1178

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add a new column type to the cart_rule table and index it #1178

wants to merge 1 commit into from

Conversation

tleon
Copy link
Contributor

@tleon tleon commented Feb 19, 2025

Questions Answers
Description? Add a new column type to the cart_rule table and index it
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #37796
Sponsor company PrestaShop SA
How to test? CI green

@tleon tleon self-assigned this Feb 19, 2025
@tleon tleon mentioned this pull request Feb 19, 2025
Merged
Progi1984
Progi1984 requested changes Feb 19, 2025
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR must be done to 9.1.0.sql

@tleon tleon force-pushed the Issue-37796-add-new-field-to-cart-rule branch from 15c484a to 0c520ee Compare February 20, 2025 13:55
@tleon tleon requested a review from Progi1984 February 20, 2025 13:55
@Quetzacoalt91 Quetzacoalt91 added this to the 7.0.0 milestone Feb 20, 2025
@tleon tleon closed this Feb 21, 2025
@tleon tleon reopened this Feb 21, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Hlavtox
Hlavtox requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use https://github.com/PrestaShop/autoupgrade/blob/dev/upgrade/php/add_column.php :-)

@Quetzacoalt91 Quetzacoalt91 added new feature Type: New feature and removed waiting for QA labels Feb 26, 2025
@Quetzacoalt91 Quetzacoalt91 removed this from the 7.0.0 milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hlavtox Hlavtox Hlavtox requested changes

@Progi1984 Progi1984 Progi1984 approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@tleon tleon

Labels
new feature Type: New feature waiting for author
Projects
PR Dashboard
Status: Reopened
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tleon @Progi1984 @Hlavtox @M0rgan01 @Quetzacoalt91 @ps-jarvis @paulnoelcholot