Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Add "unknown configuration" log #1212

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

M0rgan01
Copy link
Contributor

@M0rgan01 M0rgan01 commented Mar 3, 2025

Questions Answers
Description? Add "unknown configuration" log
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? Add unknown configuration in "config.json" file, and update via CLI

Quetzacoalt91
Quetzacoalt91 previously approved these changes Mar 3, 2025
@Quetzacoalt91 Quetzacoalt91 added this to the 7.0.0 milestone Mar 3, 2025
@Quetzacoalt91 Quetzacoalt91 added the enhancement Type: Improvement label Mar 4, 2025
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Mar 7, 2025

Tested with the following config file:

{
  "wololo": 1
}

Unfortunately it did not return my unepected key, only details about the other ones.

root@2174579875b2:/var/www/html/modules/autoupgrade# bin/console update:start --config-file-path=$PWD/config.json admin-dev
WARNING - Unknown configuration key 'PS_AUTOUP_CUSTOM_MOD_DESACT', Ignoring.
WARNING - Unknown configuration key 'PS_AUTOUP_CHANGE_DEFAULT_THEME', Ignoring.
WARNING - Unknown configuration key 'PS_AUTOUP_REGEN_EMAIL', Ignoring.
WARNING - Unknown configuration key 'PS_AUTOUP_KEEP_IMAGES', Ignoring.
WARNING - Unknown configuration key 'PS_DISABLE_OVERRIDES', Ignoring.
WARNING - Unknown configuration key 'channel', Ignoring.
WARNING - Unknown configuration key 'archive_zip', Ignoring.
WARNING - Unknown configuration key 'archive_xml', Ignoring.
WARNING - Unknown configuration key 'archive_version_num', Ignoring.
WARNING - /var/www/html/modules/autoupgrade/classes/Task/Miscellaneous/UpdateConfig.php line 74 - Undefined array key "channel"
INFO - Configuration successfully updated.
INFO - Starting update...

@M0rgan01 M0rgan01 force-pushed the unknow-config-log branch from 3722083 to a319769 Compare March 7, 2025 15:18
Copy link

sonarqubecloud bot commented Mar 7, 2025

@Quetzacoalt91
Copy link
Member

image

@Quetzacoalt91 Quetzacoalt91 merged commit fb06ac9 into PrestaShop:dev Mar 7, 2025
38 checks passed
@Quetzacoalt91 Quetzacoalt91 deleted the unknow-config-log branch March 7, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants