-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Problem with the blockreassurance module in case of a site in a subfolder #712
Fix: Problem with the blockreassurance module in case of a site in a subfolder #712
Conversation
Codencode
commented
Sep 18, 2024
•
edited by florine2623
Loading
edited by florine2623
Questions | Answers |
---|---|
Description? | If images are uploaded while the site is in a subfolder and then the folder name is changed, or the site is moved to the root directory, the uploaded images will no longer be visible. |
Type? | bug fix |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | Fixes #36956 |
Sponsor company | @Codencode |
How to test? |
Hello @Codencode! This is your first pull request on blockreassurance repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Codencode ,
I followed the same steps as I did in the issue PrestaShop/PrestaShop#36956 (comment), but I still encounter the issue.
I don't have any images displayed in BO after changing the name of my shop folder.
I changed from ps821
to ps821hello
.
Am I doing something wrong ?
Waiting for your feedback :)
Hi @florine2623, I think I understand your issue, so let me explain how the PR works.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Codencode , I hope you are doing good ^^
Indeed, after following your steps, it works as you said.
I tested in PS 8.2.1 and 9.0.0 with and without a subfolder at installation.
It looks as expected.
Here's what I have in the database :
Here's what I have in FO, BO after changing my shop folder name :
Screen.Recording.2025-03-07.at.10.56.36.mov
Thanks for the explanation, it was helpful !
It is QA ✅
Perfect, I'm glad the explanation was helpful! Thank you! |