Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better GDPR data export #113

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Better GDPR data export #113

wants to merge 1 commit into from

Conversation

pszostok
Copy link

Questions Answers
Description? There are two places where we retrieve the subscriber list, but the code inside hookActionExportGDPRData is too basic and doesn't handle all cases. As a result, we get inconsistent data — on the subscribers page in the BO, we see that a user has subscribed to the newsletter, but when downloading personal information via the psgdpr module (which uses hookActionExportGDPRData), some data are missing. It's also problematic to have two blocks of code doing the same thing.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? none
How to test? Change the newsletter setting on the customer page in the BO, and then download the personal data using the psgdpr module. With the old code, it will not retrieve any results related to the newsletter, even though the module's BO page shows the user as a subscriber.

@ps-jarvis
Copy link

Hello @pszostok!

This is your first pull request on ps_emailsubscription repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants