Add more context menu options to media gallery screen #350
Conversation
|
|
||
| val inputStream = connection.getInputStream() | ||
| val file = File( | ||
| context.getExternalFilesDir(Environment.DIRECTORY_PICTURES), |
There was a problem hiding this comment.
We should put in a cache folder instead. This will make it visible in the gallery app when you copy something.
| val inputStream = connection.getInputStream() | ||
| val file = File( | ||
| context.getExternalFilesDir(Environment.DIRECTORY_PICTURES), | ||
| "copied_image.png", |
There was a problem hiding this comment.
Maybe we should not use an extension here since you don't know if it's going to be a png or something else.
| @@ -13,3 +24,45 @@ fun copyText( | |||
| val clip = ClipData.newPlainText(label, text) | |||
| clipboard.setPrimaryClip(clip) | |||
| } | |||
|
|
|||
| suspend fun copyImageToClipboard(context: Context, imageUrl: String) { | |||
There was a problem hiding this comment.
I'm not sure if this is the best way to handle this situation. We already have a loaded image through Coil.
Maybe we can take the already rendered Bitmap and store it in a cache folder of the app. Then use that file to expose Uri with FileProvider.getUriForFile as you did below.
| @@ -162,6 +167,16 @@ fun MediaGalleryScreen( | |||
| onSaveClick = { | |||
| currentImage()?.let { eventPublisher(MediaGalleryContract.UiEvent.SaveMedia(it)) } | |||
| }, | |||
| onMediaUrlCopyClick = { | |||
| currentImage()?.url?.let { copyText(context = context, text = it) } | |||
There was a problem hiding this comment.
We should probably copy the original url of the image and not the primal cdn.
To which url is currentImage()?.url pointing to? Is it original or cdn link?
No description provided.