Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle loading and error states in profileId resolution process #351

Merged
merged 21 commits into from
Mar 4, 2025

Conversation

markocic
Copy link
Collaborator

@markocic markocic commented Mar 3, 2025

No description provided.

@markocic markocic requested a review from AleksandarIlic March 3, 2025 15:25
Copy link
Contributor

@AleksandarIlic AleksandarIlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes with room for improvement. I like the approach in general. Check the comments to see where we can simplify implementation and improve.

@AleksandarIlic AleksandarIlic self-requested a review March 4, 2025 17:43
@AleksandarIlic AleksandarIlic merged commit a1da65b into main Mar 4, 2025
1 check passed
@AleksandarIlic AleksandarIlic deleted the feature/profile-details-id-resolution branch March 4, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants