Implement NIP-92 for dimensions #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markocic
requested changes
Oct 24, 2025
...epository/src/commonMain/kotlin/net/primal/data/repository/mappers/remote/EventUriParsers.kt
Show resolved
Hide resolved
AleksandarIlic
requested changes
Jan 15, 2026
Contributor
AleksandarIlic
left a comment
AleksandarIlic
left a comment
There was a problem hiding this comment.
NIP-92 values should not be persisted as CdnResourceVariant in EventUri. CDN variants is coupled with Primal's CDN server, while NIP-92 is nostr protocol friendly. We should keep NIP-92 info as fields in EventUri (or one bigger data field) and then on the UI do the resolving - we can look for CDN and if it's missing fallback to nip92 values, or whoever seems the best later.
mehmedalijaK
changed the title
markocic
requested changes
Jan 19, 2026
app/src/main/kotlin/net/primal/android/notes/feed/note/ui/attachment/NoteAttachmentsExt.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/net/primal/android/notes/feed/note/ui/attachment/NoteAttachmentsExt.kt
Outdated
Show resolved
Hide resolved
markocic
approved these changes
Jan 19, 2026
AleksandarIlic
approved these changes
Jan 19, 2026
AleksandarIlic
pushed a commit
that referenced
this pull request
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.