Skip to content

All tests involving relaxed scanning fail #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LauriKurki opened this issue Nov 29, 2022 · 2 comments · Fixed by #18
Closed

All tests involving relaxed scanning fail #14

LauriKurki opened this issue Nov 29, 2022 · 2 comments · Fixed by #18
Assignees
Labels
bug Something isn't working

Comments

@LauriKurki
Copy link
Contributor

As PPAFM has seen major changes, now some of the features of PPSTM dependent on PPAFM have been broken as mentioned in #12. For example running tests/4N-coronene/run_test.sh fails as the LJ field used to be generated with python PATH_TO_YOUR_PROBE_PARTICLE_MODEL/generateLJFF.py -i YOUR_INPUT_FILE.cube --npy but the --npy option has been replaced with -f npy. Example error attached.

image

This requires at least changing the way PPAFM is called within PPSTM.

@LauriKurki LauriKurki added the bug Something isn't working label Nov 29, 2022
@LauriKurki LauriKurki self-assigned this Nov 29, 2022
@ondrejkrejci
Copy link
Contributor

Once more, please could you check with the newest npy version? Thank you!

@LauriKurki
Copy link
Contributor Author

LauriKurki commented Jun 13, 2023

Thanks for the update and sorry for the delay!

A couple of problems remain, and I think I can fix these apart from number 4:

  1. In PPAFM, the module pyProbeParticle was renamed to ppafm so all the imports have to be renamed in PPSTM as well
  2. Location and usage of e.g. generateLJFF.py has changed in PPAFM so instructions for generating the LJ and electrostatic FFs has to be updated as well.
  3. Installing PPAFM should be done with pip install ppafm==0.2.0a1 now instead of the script. With this we could use ppafm-generate-ljff etc. for the force fields. Edit: That version actually doesn't have the updated npz saving function, but version 0.2.0a2 was launched today. Should be available in pip soon?

4. Saving the atoms within PPAFM seems to be not working, I'm commenting more in here Edit: This was not working in the earlier release but should be now.

@LauriKurki LauriKurki linked a pull request Jun 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants