Add review fixes

ProfessionalWiki · Apr 25, 2024 · 10770a0 · 10770a0
1 parent 9dac057
commit 10770a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/PackagePrivate/Parser/Parser.php b/src/PackagePrivate/Parser/Parser.php
@@ -209,8 +209,8 @@ private function buildQualification(): Qualification {
 
 	// TODO
 	private static function genQualificationValue( ?string $flag = null ): int {
-		if ( !is_string( $flag ) || !isset(self::$map[$flag]) ) {
-			throw new InvalidArgumentException( 'Qualifier is incorrect' );
+		if ( !is_string( $flag ) || !array_key_exists( $flag, self::$map ) ) {
+			throw new InvalidArgumentException( 'Qualifier is invalid' );
 		}
 
 		return (int)self::$map[$flag];

diff --git a/tests/Unit/PackagePrivate/Parser/ParserTest.php b/tests/Unit/PackagePrivate/Parser/ParserTest.php
@@ -294,7 +294,7 @@ public function setOpenMiddleNonExtDateValues(): array {
 	}
 
 	/**
-	 * @dataProvider setCombinedUncertainAndApproximateQualifiers
+	 * @dataProvider provideCombinedUncertainAndApproximateQualifiers
 	 */
 	public function testThrowExceptionWhenUsedCombinedUncertainAndApproximateQualifiers( string $combinedUncertainAndApproximate ): void {
 		$parser = new Parser();
@@ -303,7 +303,7 @@ public function testThrowExceptionWhenUsedCombinedUncertainAndApproximateQualifi
 		$parser->createEdtf( $combinedUncertainAndApproximate );
 	}
 
-	public function setCombinedUncertainAndApproximateQualifiers(): array {
+	public function provideCombinedUncertainAndApproximateQualifiers(): array {
 		return [
 			[ '1990?~' ],
 			[ '1990~?' ],