Add approve button as an indicator

ProfessionalWiki · Aug 5, 2024 · 0d67eba · 0d67eba
1 parent 39892eb
commit 0d67eba
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/resources/PageApprovals.css b/resources/PageApprovals.css
@@ -1,7 +1,4 @@
 .page-approval-container {
-	position: absolute;
-	top: -55px;
-	right: 0;
 	z-index: 1;
 	display: flex;
 	align-items: center;

diff --git a/src/Presentation/OutputPageUiPresenter.php b/src/Presentation/OutputPageUiPresenter.php
@@ -20,8 +20,8 @@ public function presentUi( UiArguments $arguments ): void {
 			return;
 		}
 
-		$this->out->addHTML(
-			PageApprovals::getInstance()->getTemplateParser()->processTemplate(
+		$this->out->setIndicators( [
+			'page-approvals' => PageApprovals::getInstance()->getTemplateParser()->processTemplate(
 				'PageApprovalStatus',
 				[
 					'isPageApproved' => $arguments->pageIsApproved,
@@ -35,7 +35,7 @@ public function presentUi( UiArguments $arguments ): void {
 					'approvalTimestamp' => $arguments->approvalTimestamp
 				]
 			)
-		);
+		] );
 
 		$this->out->addModuleStyles( 'ext.pageApprovals.styles' );
 		$this->out->addModules( 'ext.pageApprovals.scripts' );

diff --git a/tests/EntryPoints/PageApprovalsHooksTest.php b/tests/EntryPoints/PageApprovalsHooksTest.php
@@ -52,9 +52,9 @@ public function testOnOutputPageBeforeHTMLUiIsShown() {
 
 		PageApprovalsHooks::onOutputPageBeforeHTML( $this->out );
 
-		$this->assertStringContainsString(
-			'page-approval-container',
-			$this->out->getHTML(),
+		$this->assertArrayHasKey(
+			'page-approvals',
+			$this->out->getIndicators(),
 			'The page approval status should be displayed with a matching category.'
 		);
 	}