Focusing on the input after adding category #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waximabbax
changed the title
waximabbax
changed the title
waximabbax
force-pushed
the
focus-on-input
branch
3 times, most recently
from
a46d602 to
bcb0570
Compare
| <form method="POST" action="" class="add-category-form"> | ||
| <input type="text" name="category" placeholder="New Category" required> | ||
| <form method="POST" class="add-category-form"> | ||
| <input type="text" name="category" placeholder="New Category" id="{{username}}category" required> |
There was a problem hiding this comment.
Somewhat unrelated question: what happens when username contains a "? Is it escaped?
There was a problem hiding this comment.
It works as any other user.
There was a problem hiding this comment.
@JeroenDeDauw " and ' also work fine.
malberts
reviewed
Aug 17, 2024
|
The backend HTML-building approach strikes again! |
waximabbax
force-pushed
the
focus-on-input
branch
from
bcb0570 to
c8fa684
Compare
Yeah. I wonder at what point it will force us to create separate Endpoints for POST. However, manipulating HTML with JS is also not very clean, but it is quite straightforward and doesn't require a lot of thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #114
It's a little tricky now because of our existing code and also the response we get from our POST request. It sends us the entire page. However, this script should get the job done; we can also put this JS in a separate file, although I don't see the reason to it at the moment. Please do test the code on the UI.
focus.mp4