Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming bootstrap classes #79

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

waximabbax
Copy link
Contributor

For: #78

image
image

@waximabbax waximabbax requested a review from malberts July 8, 2024 14:08
@waximabbax waximabbax force-pushed the rename-bootstrap-classes branch 2 times, most recently from 33259b1 to 0c8e57e Compare July 8, 2024 14:15
@waximabbax waximabbax force-pushed the rename-bootstrap-classes branch from 0c8e57e to 1c58872 Compare July 8, 2024 14:17
@JeroenDeDauw JeroenDeDauw merged commit b3ac29b into master Jul 8, 2024
16 checks passed
@JeroenDeDauw JeroenDeDauw deleted the rename-bootstrap-classes branch July 8, 2024 15:18
Comment on lines +1 to +2
.manage-approvers {
.form-container {
Copy link
Contributor

@malberts malberts Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting that this works. I guess MediaWiki's ResourceLoader is passing this through as LESS, because nested selectors aren't valid in plain CSS. Or is this using the relatively new https://caniuse.com/css-nesting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants