Update testGetAllCategories #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeroenDeDauw
approved these changes
Jul 12, 2024
|
I realized there was another point missing: that the list sould contain unique values. This change now causes the test to fail, unless uniqueness is not actually expected (I did not check the code to confirm this, but otherwise the assertion message is misleading). |
JeroenDeDauw
force-pushed
the
all-cats-test
branch
from
775122f to
b1ec910
Compare
|
Prod code did return unique values. Issue was the assertion checking the array keys as well. Prod code does not guarantee a non-sparse array. Fixed by changing assertSame to assertEqualsCanonicalizing |
waximabbax
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #82
Small tweak, since the test needs to verify that it works across all/multiple users.