feat: Restart/Upgrade device-plugin will not affect services. #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
chaunceyjiang
force-pushed
the
device_plugin_upgrade
branch
from
30f9dc8 to
78b401f
Compare
chaunceyjiang
commented
Jan 2, 2025
chaunceyjiang
changed the title
chaunceyjiang
force-pushed
the
device_plugin_upgrade
branch
from
78b401f to
f78e584
Compare
Mrxuexi
approved these changes
Jan 2, 2025
Signed-off-by: chaunceyjiang <[email protected]>
chaunceyjiang
force-pushed
the
device_plugin_upgrade
branch
from
f78e584 to
e375563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The most important reason that restarts affect business is that libvgpu.so is rewritten, leading to the application loading a partially written .so file. Currently, an MD5 calculation is used to determine if the file is the same, and it is not rewritten if it is different.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Test:
OCI config:
Pod:
Does this PR introduce a user-facing change?: