fix: correct device filter initialization order #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure DevicePluginFilterDevice is initialized before FilterDeviceToRegister. This fixes the initialization sequence to make device filtering work. Signed-off-by: Nimbus318 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an initialization order issue where FilterDeviceToRegister always returns false because DevicePluginFilterDevice is not initialized when the function is called. This happens because NewNVMLResourceManagers (which uses FilterDeviceToRegister) is called before the config file is read in NewNvidiaDevicePlugin.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Changes:
InitDeviceFilterfunction in plugin package to handle device filter initializationGetPluginsto ensure device filter is initialized before creating resource managersWhich issue(s) this PR fixes:
Fixes #856
Special notes for your reviewer:
Testing:
This fix ensures the device filtering feature works as intended without any side effects on existing functionality.
Does this PR introduce a user-facing change?:
No