8185 test refactor 2 #8405

garciadias · 2025-03-28T23:09:35Z

Description

This PR solves items 2 and 3 on #8185 for a few test folders.
I would merge these and proceed with the same type of change in other files if @ericspod approves.

I would like to keep these PRs small, so even if they have the same pattern of changes, merging them bit by bit would make them more manageable.

A few sentences describing the changes proposed in this pull request.

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

…combinations Signed-off-by: R. Garcia-Dias <[email protected]>

…eter combinations Signed-off-by: R. Garcia-Dias <[email protected]>

…nations Signed-off-by: R. Garcia-Dias <[email protected]>

Signed-off-by: R. Garcia-Dias <[email protected]>

…tions Signed-off-by: R. Garcia-Dias <[email protected]>

Signed-off-by: R. Garcia-Dias <[email protected]>

I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: 129f778 I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: ebae4e3 Signed-off-by: R. Garcia-Dias <[email protected]>

for more information, see https://pre-commit.ci

garciadias · 2025-04-01T15:16:13Z

Hi @ericspod,

Could you please review this PR?
I think it is all good to follow your specification on the #8185 issue.
I am sending the modification to these few tests so we can limit the size of the PR.
If you approve, I will proceed with more of these simplifications.

tests/apps/detection/test_box_transform.py

tests/data/meta_tensor/test_meta_tensor.py

tests/networks/blocks/test_patchembedding.py

Signed-off-by: R. Garcia-Dias <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: R. Garcia-Dias <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: R. Garcia-Dias <[email protected]>

…r generation Signed-off-by: R. Garcia-Dias <[email protected]>

…leaner generation Signed-off-by: R. Garcia-Dias <[email protected]>

…ner generation Signed-off-by: R. Garcia-Dias <[email protected]>

…aner generation Signed-off-by: R. Garcia-Dias <[email protected]>

…ner generation Signed-off-by: R. Garcia-Dias <[email protected]>

…generation Signed-off-by: R. Garcia-Dias <[email protected]>

…MONAI into 8185-test-refactor-2

…neration Signed-off-by: R. Garcia-Dias <[email protected]>

…aner generation Signed-off-by: R. Garcia-Dias <[email protected]>

…for cleaner generation Signed-off-by: R. Garcia-Dias <[email protected]>

…ner test generation Signed-off-by: R. Garcia-Dias <[email protected]>

…r test generation Signed-off-by: R. Garcia-Dias <[email protected]>

…or cleaner test generation Signed-off-by: R. Garcia-Dias <[email protected]>

…er test generation Signed-off-by: R. Garcia-Dias <[email protected]>

…r test generation Signed-off-by: R. Garcia-Dias <[email protected]>

Signed-off-by: R. Garcia-Dias <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Rafael Garcia-Dias <[email protected]>

Signed-off-by: R. Garcia-Dias <[email protected]>

This reverts commit 1fc0a5b.

I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: 241e24c I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: 2edf166 I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: 2430ac8 I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: bb54c57 I, R. Garcia-Dias <[email protected]>, hereby add my Signed-off-by to this commit: cd1b4fb Signed-off-by: R. Garcia-Dias <[email protected]>

for more information, see https://pre-commit.ci

garciadias and others added 12 commits February 27, 2025 15:59

Merge branch 'dev' into 8185-test-refactor-2

57d7b09

Merge remote-tracking branch 'upstream/dev' into 8185-test-refactor-2

5342cba

Refactor self-attention test cases to use dict_product for parameter …

0139125

…combinations Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor PatchEmbeddingBlock test cases to use dict_product for param…

836cf6e

…eter combinations Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor RetinaNet test cases to use dict_product for parameter combi…

b2ccb26

…nations Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test_meta_tensor to use dict_product for parameter combinations

0735dfd

Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test_box_transform to use dict_product for parameter combina…

45622d4

…tions Signed-off-by: R. Garcia-Dias <[email protected]>

Autofix

129f778

Fix mypy error

ebae4e3

Fix missing parameter

482e5bf

Signed-off-by: R. Garcia-Dias <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

c06cad1

for more information, see https://pre-commit.ci

ericspod reviewed Apr 4, 2025

View reviewed changes

tests/apps/detection/test_box_transform.py Outdated Show resolved Hide resolved

ericspod reviewed Apr 4, 2025

View reviewed changes

tests/data/meta_tensor/test_meta_tensor.py Outdated Show resolved Hide resolved

ericspod reviewed Apr 4, 2025

View reviewed changes

tests/networks/blocks/test_patchembedding.py Outdated Show resolved Hide resolved

garciadias and others added 14 commits April 10, 2025 17:32

revert change to tests/apps/detection/test_box_transform.py

a5596d7

Signed-off-by: R. Garcia-Dias <[email protected]>

redesign dict_product to make more readable

b46ccc0

Signed-off-by: R. Garcia-Dias <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

6077ccd

for more information, see https://pre-commit.ci

add license to temporary test

cd5f790

Signed-off-by: R. Garcia-Dias <[email protected]>

fix test param name

84d85ea

Signed-off-by: R. Garcia-Dias <[email protected]>

Simplify with list comprehension

336b287

Signed-off-by: R. Garcia-Dias <[email protected]>

autofix

0cedbb5

Signed-off-by: R. Garcia-Dias <[email protected]>

N806 not catch locally, but in CI

a9b0fc9

Signed-off-by: R. Garcia-Dias <[email protected]>

dict_product function to accept Iterable[Any] for improved flexibility

d2259b9

Signed-off-by: R. Garcia-Dias <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

5922e2a

for more information, see https://pre-commit.ci

autofix

ef2388e

Signed-off-by: R. Garcia-Dias <[email protected]>

Fix test mistakes

016d3b0

Signed-off-by: R. Garcia-Dias <[email protected]>

autofix

ce798d7

Signed-off-by: R. Garcia-Dias <[email protected]>

fix mypy errora

8fad281

Signed-off-by: R. Garcia-Dias <[email protected]>

garciadias and others added 24 commits May 9, 2025 17:32

Refactor test cases in test_mednext.py to use dict_product for cleane…

b4c81f1

…r generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_segresnet_ds.py to use dict_product for c…

61d20d3

…leaner generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_segresnet.py to use dict_product for clea…

1dc304e

…ner generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_swin_unetr.py to use dict_product for cle…

79bc4f2

…aner generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_transchex.py to use dict_product for clea…

3049126

…ner generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_unetr.py to use dict_product for cleaner …

91ff49a

…generation Signed-off-by: R. Garcia-Dias <[email protected]>

Merge branch '8185-test-refactor-2' of https://github.com/garciadias/…

a683162

…MONAI into 8185-test-refactor-2

Refactor test cases in test_vit.py to use dict_product for cleaner ge…

fbf47cd

…neration Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_vitautoenc.py to use dict_product for cle…

e8c0270

…aner generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_spatial_resampled.py to use dict_product …

2a010b1

…for cleaner generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_splitdimd.py to use dict_product for clea…

0240249

…ner test generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_spacing.py to use dict_product for cleane…

ce33936

…r test generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_spatial_resample.py to use dict_product f…

51a94c2

…or cleaner test generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_pad_mode.py to use dict_product for clean…

74741e7

…er test generation Signed-off-by: R. Garcia-Dias <[email protected]>

Refactor test cases in test_spacing.py to use dict_product for cleane…

60f7201

…r test generation Signed-off-by: R. Garcia-Dias <[email protected]>

Remove test_utils.py

9214fca

Signed-off-by: R. Garcia-Dias <[email protected]>

Merge remote-tracking branch 'upstream/dev' into 8185-test-refactor-2

76033a6

Apply suggestions from code review

1e3339d

Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Rafael Garcia-Dias <[email protected]>

autofix

e00df4d

Signed-off-by: R. Garcia-Dias <[email protected]>

Merge remote-tracking branch 'upstream/dev' into 8185-test-refactor-2

e337c8a

autofix

241e24c

reroll modified tests

1fc0a5b

Signed-off-by: R. Garcia-Dias <[email protected]>

Merge remote-tracking branch 'upstream/dev' into 8185-test-refactor-2

080fc72

Remove wrong param.

2edf166

garciadias force-pushed the 8185-test-refactor-2 branch from 5ae6312 to 2edf166 Compare May 16, 2025 12:31

garciadias and others added 5 commits May 16, 2025 13:41

autofix

2430ac8

Revert "reroll modified tests"

bb54c57

This reverts commit 1fc0a5b.

Fix gibbs noise tests

cd1b4fb

[pre-commit.ci] auto fixes from pre-commit.com hooks

1576690

for more information, see https://pre-commit.ci

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8185 test refactor 2 #8405

8185 test refactor 2 #8405

garciadias commented Mar 28, 2025 •

edited

Loading

garciadias commented Apr 1, 2025

8185 test refactor 2 #8405

Are you sure you want to change the base?

8185 test refactor 2 #8405

Conversation

garciadias commented Mar 28, 2025 • edited Loading

Description

Types of changes

garciadias commented Apr 1, 2025

garciadias commented Mar 28, 2025 •

edited

Loading