Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚖️ [Artifact 1045] ブラックホール・ミニの弾が一定時間経過後に強制的に起動するように #1057

Merged
merged 10 commits into from
Mar 6, 2025

Conversation

Lapis-LJA
Copy link
Contributor

Fix #682

Comment on lines 20 to 22
data modify storage asset:object Field.Speed set value 1
data modify storage asset:object Field.Range set value 50
data modify storage asset:object Field.MovePerStep set value 0.6
Copy link
Member

@haiiro2gou haiiro2gou Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: 前より速度も射程も小さくなってるけど大丈夫なの?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

射程は短くなってるので直す 弾速は...どれくらいなのこれ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

弾速は...どれくらいなのこれ?

もともとは 0.75m/t を lib:motion/ で付与していた
バニラの仕様で速度減衰みたいなのがなければそれで一定のはず

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Range100のMovePerStep0.75かな

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Range100のMovePerStep0.75かな

そこまで MovePerStep が大きいとすり抜けまくりそう

@haiiro2gou
Copy link
Member

haiiro2gou commented Mar 6, 2025

わざわざ別 Object にせんでもなー、という気持ちにはなった
d36a62b

@Lapis-LJA Lapis-LJA requested a review from haiiro2gou March 6, 2025 16:45
@Lapis-LJA
Copy link
Contributor Author

わざわざ別 Object にせんでもなー、という気持ちにはなった
飛翔体抽象を継承した上で飛距離が尽きたら、という実装考えたときにこうすべきかな~ってなったから、load使っても良かったなとは思うんだけどね

Copy link
Member

@haiiro2gou haiiro2gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haiiro2gou haiiro2gou changed the title ♻️ [Artifact1045] ブラックホール・ミニの処理をObjectAssetへ移行 ⚖️ [Artifact 1045] ブラックホール・ミニの弾が一定時間経過後に強制的に起動するように Mar 6, 2025
@haiiro2gou haiiro2gou merged commit 5b4521b into master Mar 6, 2025
2 checks passed
@haiiro2gou haiiro2gou deleted the dev/lapis_object1042 branch March 6, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[神器1045] ブラックホール・ミニが一定時間ブロックに接触しないと消滅する
2 participants