🍱 [Artifact 1293] 僧兵用治癒術式を作成#1652
Open
haiiro2gou wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new artifact (ID: 1293, “僧兵用治癒術式”) to the datapack’s artifact system, wiring it into the standard register/load/give/onClick flows and implementing its healing behavior with a chained-use mechanic.
Changes:
- Registered artifact 1293 into function tags for registration, load initialization, give trigger, and carrot-on-a-stick click triggering.
- Implemented artifact 1293’s give definition (name/lore/cost/cooldowns) and registration into rarity pools.
- Implemented runtime logic (load scoreboard init, trigger condition checks, main heal execution with remaining-count tracking).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Asset/data/asset/tags/functions/artifact/register.json | Adds 1293 register function to the artifact registration tag. |
| Asset/data/asset/tags/functions/artifact/load.json | Adds 1293 load initializer to the artifact load tag. |
| Asset/data/asset/tags/functions/artifact/give.json | Adds 1293 give trigger to the artifact give tag. |
| Asset/data/asset/tags/functions/artifact/click.carrot_on_a_stick.json | Wires 1293 trigger into onClick dispatch (and reorders 1284/1285 entries). |
| Asset/data/asset/functions/artifact/1293.rite_of_bone_and_flesh/trigger/0.load.mcfunction | Creates scoreboard objectives used by the artifact. |
| Asset/data/asset/functions/artifact/1293.rite_of_bone_and_flesh/trigger/1.trigger.mcfunction | Dispatches to condition check when equipped artifact ID matches 1293. |
| Asset/data/asset/functions/artifact/1293.rite_of_bone_and_flesh/trigger/2.check_condition.mcfunction | Implements chained-use reset logic and calls common condition checks. |
| Asset/data/asset/functions/artifact/1293.rite_of_bone_and_flesh/trigger/3.main.mcfunction | Executes MP/use handling, updates chain counters, and performs healing. |
| Asset/data/asset/functions/artifact/1293.rite_of_bone_and_flesh/register.mcfunction | Adds artifact ID 1293 to rarity registries. |
| Asset/data/asset/functions/artifact/1293.rite_of_bone_and_flesh/give/1.trigger.mcfunction | Routes give calls for ID 1293 to the give definition. |
| Asset/data/asset/functions/artifact/1293.rite_of_bone_and_flesh/give/2.give.mcfunction | Defines the artifact item metadata, costs, cooldowns, and availability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
haiiro2gou
force-pushed
the
dev/haiiro_artifact1297
branch
from
1268f2b to
347ca7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.